Create Block: Enhancements to Gutenpride tutorial template #28215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
|
@gziolo, @fabiankaegy I tested the template and it looks good. No errors. Everything is working as it should.
|
gziolo
added a commit
that referenced
this pull request
Jan 15, 2021
* Create Block: Enhancements to the tutorial template * Apply coding style changes and align comments with the default template * Ensure that all validations pass for scaffolded block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #27881.
This PR fixes linting errors reported in the scaffolded block with:
wp-scripts lint-jsandwp-scripts lint-jsIn addition to that, it brings all the latest fixes applied to the
esnexttemplate.I also discovered that the comment that lists allowed categories wasn't updated in templates.
Finally, I added the
examplefor the block to have a nice preview on the front-end.How has this been tested?
npx wp-create-block --template @wordpress/create-block-tutorial-template --no-wp-scripts cd gutenpride ../node_modules/.bin/wp-scripts format-js ../node_modules/.bin/wp-scripts lint-js ../node_modules/.bin/wp-scripts lint-style ../node_modules/.bin/wp-scripts buildObserve that the block is scaffolded, there are no errors reported and you are able to activate the block (plugin) in the editor.
Screenshots
It works for me:
Types of changes
Checklist: