-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile Release v1.44.1 #28203
Merged
Merged
Mobile Release v1.44.1 #28203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Range cell component is used in multiple components but not all of them require the onComplete handler so it should be optional.
…#28121) * Remove px suffix from fontSize for Android paragraph * Issue does not seem to be limited to android on latest gutenberg master * Move fontSize char removal to richtext to account for multiple block errors
cameronvoell
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Jan 14, 2021
* WC: Added move to top and bottom functionality via long pressing BlockMover buttons and clicking the button on the BottomSheet Picker. * WIP: Unit tests. * WC: WIP unit tests for add move to top and bottom * WC: Moving UI tests to gutenberg with other UI tests instead of keeping at gutenberg-mobile. Adding more convenience functions to EditorPage. * WIP: Unit tests. * WC: Adding icon and title to picker for move to top/bottom. * WC: Cleaning up code. * WC: Fixing merge issue where import was changed to const. * WC: Changing all imports to requires as per jest bug. * WC: Removing before/afterAll blocks from UI tests. * WC: Removing e2e tests to issue-1191-add-move-to-top-bottom-ui-tests branch. * WC: Updating imports to fall in line with other files. Co-authored-by: Wendy Chen <[email protected]>
3 tasks
jd-alexander
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the changes being released are as expected. LGTM 🚢
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.44.1 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3006
Checklist: