Hide the theme without comments.php deprecation message #28128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Full Site Editing
[Type] Experimental
gziolo
reviewed
Jan 12, 2021
|
Size Change: -319 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
Have you considered adding a temporary filter to core to allow Gutenberg to disable the deprecation message in a nicer way? For example in At some point it will need a core solution anyway once FSE themes take off.
|
|
@swissspidy yes, my idea was to avoid touching core yet, because FSE is still experimental right and it's unclear whether the block will continue to exist as is or be refactored later to be something closer to the Query block (we might have both) So if we do keep this in FSE when the landing to Core is close, we should probably just remove the deprecation in Core for fie-themes. (add a check there) |
These are not used at in FSE themes, comment.php is used by the Post Comments block. |
|
Looking at
This isn't very elegant for two reasons:
But it should nevertheless work reliably and without having to introduce new hooks or manipulate the server response in |
It might be simpler in terms of readability to disable and enable this filter around |
I'm ok with that :) |
|
I like the filter's approach. Thanks :) |
mcsf
reviewed
Jan 13, 2021
mcsf
reviewed
Jan 13, 2021
aristath
requested changes
Jan 13, 2021
aristath
approved these changes
Jan 13, 2021
|
Do we have an issue opened to figure out what to do with the comments template more broadly? We should avoid |
|
Ah, great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28045
I'm not very proud of what I did to achieve the removal of this deprecation but at the moment, I don't see any other way to do it. Open to suggestions
Testing instructions