Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw handling: fix pasting special spaces #28077

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Conversation

ellatrix
Copy link
Member

Description

Fixes #15649.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link

github-actions bot commented Jan 10, 2021

Size Change: +374 B (0%)

Total Size: 1.4 MB

Filename Size Change
build/a11y/index.js 1.14 kB +1 B (0%)
build/annotations/index.js 3.78 kB -1 B (0%)
build/autop/index.js 2.82 kB +3 B (0%)
build/block-directory/index.js 8.63 kB -2 B (0%)
build/block-editor/index.js 125 kB +523 B (0%)
build/block-editor/style-rtl.css 12.3 kB +176 B (+1%)
build/block-editor/style.css 12.3 kB +176 B (+1%)
build/block-library/blocks/cover/editor-rtl.css 599 B +209 B (+54%) 🆘
build/block-library/blocks/cover/editor.css 599 B +210 B (+54%) 🆘
build/block-library/blocks/gallery/style-rtl.css 1.11 kB +30 B (+3%)
build/block-library/blocks/gallery/style.css 1.1 kB +30 B (+3%)
build/block-library/blocks/navigation-link/editor-rtl.css 620 B -61 B (-9%)
build/block-library/blocks/navigation-link/editor.css 621 B -62 B (-9%)
build/block-library/blocks/navigation-link/style-rtl.css 671 B -23 B (-3%)
build/block-library/blocks/navigation-link/style.css 668 B -24 B (-3%)
build/block-library/blocks/navigation/editor-rtl.css 1.09 kB -254 B (-19%) 👏
build/block-library/blocks/navigation/editor.css 1.09 kB -250 B (-19%) 👏
build/block-library/blocks/navigation/style-rtl.css 204 B -9 B (-4%)
build/block-library/blocks/navigation/style.css 205 B -9 B (-4%)
build/block-library/blocks/paragraph/style-rtl.css 247 B -41 B (-14%) 👏
build/block-library/blocks/paragraph/style.css 248 B -41 B (-14%) 👏
build/block-library/blocks/social-links/editor-rtl.css 769 B +73 B (+10%) ⚠️
build/block-library/blocks/social-links/editor.css 769 B +73 B (+10%) ⚠️
build/block-library/blocks/social-links/style-rtl.css 1.32 kB -1 B (0%)
build/block-library/blocks/verse/editor-rtl.css 50 B -12 B (-19%) 👏
build/block-library/blocks/verse/editor.css 50 B -12 B (-19%) 👏
build/block-library/editor-rtl.css 9.57 kB +33 B (0%)
build/block-library/editor.css 9.58 kB +50 B (+1%)
build/block-library/index.js 147 kB -738 B (0%)
build/block-library/style-rtl.css 8.85 kB +17 B (0%)
build/block-library/style.css 8.85 kB +13 B (0%)
build/block-library/theme-rtl.css 700 B -36 B (-5%)
build/block-library/theme.css 701 B -35 B (-5%)
build/blocks/index.js 48.3 kB +20 B (0%)
build/components/index.js 283 kB -84 B (0%)
build/components/style-rtl.css 16.2 kB +579 B (+4%)
build/components/style.css 16.2 kB +578 B (+4%)
build/core-data/index.js 16.7 kB +1 B (0%)
build/customize-widgets/index.js 3.95 kB -3 B (0%)
build/data-controls/index.js 829 B +1 B (0%)
build/data/index.js 8.87 kB -4 B (0%)
build/date/index.js 31.8 kB -1 B (0%)
build/dom-ready/index.js 576 B -1 B (0%)
build/dom/index.js 4.96 kB +28 B (+1%)
build/edit-navigation/index.js 11.9 kB +116 B (+1%)
build/edit-navigation/style-rtl.css 1.31 kB +30 B (+2%)
build/edit-navigation/style.css 1.31 kB +30 B (+2%)
build/edit-post/index.js 306 kB -2 B (0%)
build/edit-post/style-rtl.css 6.86 kB +49 B (+1%)
build/edit-post/style.css 6.85 kB +51 B (+1%)
build/edit-site/index.js 27.1 kB -121 B (0%)
build/edit-site/style-rtl.css 4.5 kB +31 B (+1%)
build/edit-site/style.css 4.49 kB +28 B (+1%)
build/editor/editor-styles-rtl.css 347 B -196 B (-36%) 🎉
build/editor/editor-styles.css 347 B -198 B (-36%) 🎉
build/editor/index.js 41.8 kB -316 B (-1%)
build/editor/style-rtl.css 3.9 kB -4 B (0%)
build/editor/style.css 3.9 kB -4 B (0%)
build/format-library/index.js 6.75 kB -5 B (0%)
build/hooks/index.js 2.28 kB -1 B (0%)
build/html-entities/index.js 623 B +1 B (0%)
build/is-shallow-equal/index.js 698 B -1 B (0%)
build/keycodes/index.js 1.95 kB -1 B (0%)
build/list-reusable-blocks/index.js 3.15 kB -1 B (0%)
build/media-utils/index.js 5.34 kB -1 B (0%)
build/notices/index.js 1.85 kB -2 B (0%)
build/nux/index.js 3.41 kB +5 B (0%)
build/plugins/index.js 2.89 kB -6 B (0%)
build/react-i18n/index.js 1.46 kB -2 B (0%)
build/redux-routine/index.js 2.84 kB +4 B (0%)
build/reusable-blocks/index.js 3.78 kB -1 B (0%)
build/rich-text/index.js 13.4 kB +4 B (0%)
build/server-side-render/index.js 2.58 kB -235 B (-8%)
build/token-list/index.js 1.27 kB +1 B (0%)
build/url/index.js 3.02 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/api-fetch/index.js 3.4 kB 0 B
build/blob/index.js 664 B 0 B
build/block-directory/style-rtl.css 1 kB 0 B
build/block-directory/style.css 1.01 kB 0 B
build/block-library/blocks/archives/editor-rtl.css 61 B 0 B
build/block-library/blocks/archives/editor.css 60 B 0 B
build/block-library/blocks/audio/editor-rtl.css 58 B 0 B
build/block-library/blocks/audio/editor.css 58 B 0 B
build/block-library/blocks/audio/style-rtl.css 112 B 0 B
build/block-library/blocks/audio/style.css 112 B 0 B
build/block-library/blocks/block/editor-rtl.css 161 B 0 B
build/block-library/blocks/block/editor.css 161 B 0 B
build/block-library/blocks/button/editor-rtl.css 475 B 0 B
build/block-library/blocks/button/editor.css 474 B 0 B
build/block-library/blocks/button/style-rtl.css 479 B 0 B
build/block-library/blocks/button/style.css 479 B 0 B
build/block-library/blocks/buttons/editor-rtl.css 315 B 0 B
build/block-library/blocks/buttons/editor.css 315 B 0 B
build/block-library/blocks/buttons/style-rtl.css 364 B 0 B
build/block-library/blocks/buttons/style.css 363 B 0 B
build/block-library/blocks/calendar/style-rtl.css 208 B 0 B
build/block-library/blocks/calendar/style.css 208 B 0 B
build/block-library/blocks/categories/editor-rtl.css 84 B 0 B
build/block-library/blocks/categories/editor.css 83 B 0 B
build/block-library/blocks/categories/style-rtl.css 79 B 0 B
build/block-library/blocks/categories/style.css 79 B 0 B
build/block-library/blocks/code/style-rtl.css 90 B 0 B
build/block-library/blocks/code/style.css 90 B 0 B
build/block-library/blocks/columns/editor-rtl.css 190 B 0 B
build/block-library/blocks/columns/editor.css 190 B 0 B
build/block-library/blocks/columns/style-rtl.css 421 B 0 B
build/block-library/blocks/columns/style.css 421 B 0 B
build/block-library/blocks/cover/style-rtl.css 1.24 kB 0 B
build/block-library/blocks/cover/style.css 1.24 kB 0 B
build/block-library/blocks/embed/editor-rtl.css 486 B 0 B
build/block-library/blocks/embed/editor.css 486 B 0 B
build/block-library/blocks/embed/style-rtl.css 401 B 0 B
build/block-library/blocks/embed/style.css 400 B 0 B
build/block-library/blocks/file/editor-rtl.css 199 B 0 B
build/block-library/blocks/file/editor.css 198 B 0 B
build/block-library/blocks/file/style-rtl.css 248 B 0 B
build/block-library/blocks/file/style.css 248 B 0 B
build/block-library/blocks/freeform/editor-rtl.css 2.45 kB 0 B
build/block-library/blocks/freeform/editor.css 2.45 kB 0 B
build/block-library/blocks/gallery/editor-rtl.css 689 B 0 B
build/block-library/blocks/gallery/editor.css 690 B 0 B
build/block-library/blocks/group/editor-rtl.css 318 B 0 B
build/block-library/blocks/group/editor.css 317 B 0 B
build/block-library/blocks/group/style-rtl.css 57 B 0 B
build/block-library/blocks/group/style.css 57 B 0 B
build/block-library/blocks/heading/editor-rtl.css 129 B 0 B
build/block-library/blocks/heading/editor.css 129 B 0 B
build/block-library/blocks/heading/style-rtl.css 76 B 0 B
build/block-library/blocks/heading/style.css 76 B 0 B
build/block-library/blocks/html/editor-rtl.css 281 B 0 B
build/block-library/blocks/html/editor.css 281 B 0 B
build/block-library/blocks/image/editor-rtl.css 717 B 0 B
build/block-library/blocks/image/editor.css 716 B 0 B
build/block-library/blocks/image/style-rtl.css 476 B 0 B
build/block-library/blocks/image/style.css 478 B 0 B
build/block-library/blocks/latest-comments/editor-rtl.css 159 B 0 B
build/block-library/blocks/latest-comments/editor.css 158 B 0 B
build/block-library/blocks/latest-comments/style-rtl.css 269 B 0 B
build/block-library/blocks/latest-comments/style.css 269 B 0 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B 0 B
build/block-library/blocks/latest-posts/editor.css 137 B 0 B
build/block-library/blocks/latest-posts/style-rtl.css 523 B 0 B
build/block-library/blocks/latest-posts/style.css 522 B 0 B
build/block-library/blocks/list/editor-rtl.css 65 B 0 B
build/block-library/blocks/list/editor.css 65 B 0 B
build/block-library/blocks/list/style-rtl.css 63 B 0 B
build/block-library/blocks/list/style.css 63 B 0 B
build/block-library/blocks/media-text/editor-rtl.css 191 B 0 B
build/block-library/blocks/media-text/editor.css 191 B 0 B
build/block-library/blocks/media-text/style-rtl.css 535 B 0 B
build/block-library/blocks/media-text/style.css 532 B 0 B
build/block-library/blocks/more/editor-rtl.css 434 B 0 B
build/block-library/blocks/more/editor.css 434 B 0 B
build/block-library/blocks/nextpage/editor-rtl.css 395 B 0 B
build/block-library/blocks/nextpage/editor.css 395 B 0 B
build/block-library/blocks/page-list/editor-rtl.css 215 B 0 B
build/block-library/blocks/page-list/editor.css 215 B 0 B
build/block-library/blocks/page-list/style-rtl.css 527 B 0 B
build/block-library/blocks/page-list/style.css 526 B 0 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B 0 B
build/block-library/blocks/paragraph/editor.css 157 B 0 B
build/block-library/blocks/post-author/editor-rtl.css 209 B 0 B
build/block-library/blocks/post-author/editor.css 209 B 0 B
build/block-library/blocks/post-author/style-rtl.css 183 B 0 B
build/block-library/blocks/post-author/style.css 184 B 0 B
build/block-library/blocks/post-comments-form/style-rtl.css 250 B 0 B
build/block-library/blocks/post-comments-form/style.css 250 B 0 B
build/block-library/blocks/post-content/editor-rtl.css 139 B 0 B
build/block-library/blocks/post-content/editor.css 139 B 0 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B 0 B
build/block-library/blocks/post-excerpt/editor.css 73 B 0 B
build/block-library/blocks/post-featured-image/editor-rtl.css 338 B 0 B
build/block-library/blocks/post-featured-image/editor.css 338 B 0 B
build/block-library/blocks/post-featured-image/style-rtl.css 100 B 0 B
build/block-library/blocks/post-featured-image/style.css 100 B 0 B
build/block-library/blocks/preformatted/style-rtl.css 63 B 0 B
build/block-library/blocks/preformatted/style.css 63 B 0 B
build/block-library/blocks/pullquote/editor-rtl.css 183 B 0 B
build/block-library/blocks/pullquote/editor.css 183 B 0 B
build/block-library/blocks/pullquote/style-rtl.css 318 B 0 B
build/block-library/blocks/pullquote/style.css 318 B 0 B
build/block-library/blocks/query-loop/editor-rtl.css 90 B 0 B
build/block-library/blocks/query-loop/editor.css 89 B 0 B
build/block-library/blocks/query-loop/style-rtl.css 315 B 0 B
build/block-library/blocks/query-loop/style.css 317 B 0 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B 0 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B 0 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B 0 B
build/block-library/blocks/query-pagination/editor.css 262 B 0 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B 0 B
build/block-library/blocks/query-pagination/style.css 168 B 0 B
build/block-library/blocks/query-title/editor-rtl.css 86 B 0 B
build/block-library/blocks/query-title/editor.css 86 B 0 B
build/block-library/blocks/query/editor-rtl.css 814 B 0 B
build/block-library/blocks/query/editor.css 812 B 0 B
build/block-library/blocks/quote/editor-rtl.css 61 B 0 B
build/block-library/blocks/quote/editor.css 61 B 0 B
build/block-library/blocks/quote/style-rtl.css 169 B 0 B
build/block-library/blocks/quote/style.css 169 B 0 B
build/block-library/blocks/rss/editor-rtl.css 201 B 0 B
build/block-library/blocks/rss/editor.css 202 B 0 B
build/block-library/blocks/rss/style-rtl.css 290 B 0 B
build/block-library/blocks/rss/style.css 290 B 0 B
build/block-library/blocks/search/editor-rtl.css 165 B 0 B
build/block-library/blocks/search/editor.css 165 B 0 B
build/block-library/blocks/search/style-rtl.css 342 B 0 B
build/block-library/blocks/search/style.css 344 B 0 B
build/block-library/blocks/separator/editor-rtl.css 99 B 0 B
build/block-library/blocks/separator/editor.css 99 B 0 B
build/block-library/blocks/separator/style-rtl.css 236 B 0 B
build/block-library/blocks/separator/style.css 236 B 0 B
build/block-library/blocks/shortcode/editor-rtl.css 504 B 0 B
build/block-library/blocks/shortcode/editor.css 504 B 0 B
build/block-library/blocks/site-logo/editor-rtl.css 201 B 0 B
build/block-library/blocks/site-logo/editor.css 201 B 0 B
build/block-library/blocks/site-logo/style-rtl.css 115 B 0 B
build/block-library/blocks/site-logo/style.css 115 B 0 B
build/block-library/blocks/social-link/editor-rtl.css 164 B 0 B
build/block-library/blocks/social-link/editor.css 165 B 0 B
build/block-library/blocks/social-links/style.css 1.32 kB 0 B
build/block-library/blocks/spacer/editor-rtl.css 317 B 0 B
build/block-library/blocks/spacer/editor.css 317 B 0 B
build/block-library/blocks/spacer/style-rtl.css 48 B 0 B
build/block-library/blocks/spacer/style.css 48 B 0 B
build/block-library/blocks/table/editor-rtl.css 478 B 0 B
build/block-library/blocks/table/editor.css 478 B 0 B
build/block-library/blocks/table/style-rtl.css 402 B 0 B
build/block-library/blocks/table/style.css 402 B 0 B
build/block-library/blocks/tag-cloud/editor-rtl.css 118 B 0 B
build/block-library/blocks/tag-cloud/editor.css 118 B 0 B
build/block-library/blocks/tag-cloud/style-rtl.css 94 B 0 B
build/block-library/blocks/tag-cloud/style.css 94 B 0 B
build/block-library/blocks/template-part/editor-rtl.css 557 B 0 B
build/block-library/blocks/template-part/editor.css 556 B 0 B
build/block-library/blocks/term-description/editor-rtl.css 90 B 0 B
build/block-library/blocks/term-description/editor.css 90 B 0 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B 0 B
build/block-library/blocks/text-columns/editor.css 95 B 0 B
build/block-library/blocks/text-columns/style-rtl.css 166 B 0 B
build/block-library/blocks/text-columns/style.css 166 B 0 B
build/block-library/blocks/verse/style-rtl.css 87 B 0 B
build/block-library/blocks/verse/style.css 87 B 0 B
build/block-library/blocks/video/editor-rtl.css 504 B 0 B
build/block-library/blocks/video/editor.css 503 B 0 B
build/block-library/blocks/video/style-rtl.css 187 B 0 B
build/block-library/blocks/video/style.css 187 B 0 B
build/block-library/common-rtl.css 1.1 kB 0 B
build/block-library/common.css 1.1 kB 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/compose/index.js 11.1 kB 0 B
build/customize-widgets/style-rtl.css 168 B 0 B
build/customize-widgets/style.css 168 B 0 B
build/deprecated/index.js 769 B 0 B
build/edit-widgets/index.js 20.1 kB 0 B
build/edit-widgets/style-rtl.css 3.2 kB 0 B
build/edit-widgets/style.css 3.2 kB 0 B
build/element/index.js 4.61 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/style-rtl.css 637 B 0 B
build/format-library/style.css 639 B 0 B
build/i18n/index.js 4.01 kB 0 B
build/keyboard-shortcuts/index.js 2.53 kB 0 B
build/list-reusable-blocks/style-rtl.css 629 B 0 B
build/list-reusable-blocks/style.css 628 B 0 B
build/nux/style-rtl.css 731 B 0 B
build/nux/style.css 727 B 0 B
build/primitives/index.js 1.42 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/reusable-blocks/style-rtl.css 225 B 0 B
build/reusable-blocks/style.css 225 B 0 B
build/shortcode/index.js 1.7 kB 0 B
build/viewport/index.js 1.86 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

Base automatically changed from master to trunk March 1, 2021 15:45
@noisysocks
Copy link
Member

I followed the steps in #15649 (comment) and am still seeing the issue where pasting a thin space into the editor does nothing.

@ellatrix
Copy link
Member Author

@noisysocks Could you share what's logged in the console after pasting the thin space in Gutenberg?

@noisysocks
Copy link
Member

noisysocks commented Mar 15, 2021

I get this:

Received HTML:

 <empty string>

Received plain text:

  

Processed inline HTML:

 <empty string>

I confirmed that there's a thin space in there by copy and pasting some of the output to console.txt and running:

$ xxd -b console.txt
00000000: 01010010 01100101 01100011 01100101 01101001 01110110  Receiv
00000006: 01100101 01100100 00100000 01110000 01101100 01100001  ed pla
0000000c: 01101001 01101110 00100000 01110100 01100101 01111000  in tex
00000012: 01110100 00111010 00001010 00001010 00100000 11100010  t:.. .
00000018: 10000000 10001001

The last 3 bytes there are the UTF-8 encoding of a thin space (U+2009).

@ellatrix
Copy link
Member Author

Ok, so your thin space is in plain text?

@ellatrix
Copy link
Member Author

@noisysocks Thanks, that was helpful. The markdown converter is stripping that whitespace, so I made it skip if the plain text is just whitespace.

@ellatrix ellatrix requested a review from noisysocks March 16, 2021 11:59
@ellatrix ellatrix added [Feature] Paste [Type] Bug An existing feature does not function as intended labels Mar 16, 2021
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! 🎉

@ellatrix ellatrix merged commit f5d0925 into trunk Mar 17, 2021
@ellatrix ellatrix deleted the fix/paste-special-spaces branch March 17, 2021 10:03
@github-actions github-actions bot added this to the Gutenberg 10.3 milestone Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Paste [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paste handler strips white space characters
2 participants