Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface: Remove deprecated prop from InterfaceSkeleton #28034

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Interface: Remove deprecated prop from InterfaceSkeleton #28034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/interface/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Breaking Changes

- `leftSidebar` prop in `InterfaceSkeleton` component was removed ([#26517](https://github.com/WordPress/gutenberg/pull/26517). Use `secondarySidebar` prop instead.

## 0.11.0 (2020-12-17)

### New Feature
Expand Down
12 changes: 0 additions & 12 deletions packages/interface/src/components/interface-skeleton/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import classnames from 'classnames';
*/
import { forwardRef, useEffect, useRef } from '@wordpress/element';
import { __unstableUseNavigateRegions as useNavigateRegions } from '@wordpress/components';
import deprecated from '@wordpress/deprecated';
import { __ } from '@wordpress/i18n';

function useHTMLClass( className ) {
Expand Down Expand Up @@ -36,8 +35,6 @@ function InterfaceSkeleton(
actions,
labels,
className,
// Deprecated props.
leftSidebar,
shortcuts,
},
ref
Expand Down Expand Up @@ -69,15 +66,6 @@ function InterfaceSkeleton(

const mergedLabels = { ...defaultLabels, ...labels };

if ( leftSidebar ) {
deprecated( 'leftSidebar prop in InterfaceSkeleton component', {
alternative: 'secondarySidebar prop',
version: '9.7.0',
plugin: 'Gutenberg',
} );
secondarySidebar = leftSidebar;
}

return (
<div
ref={ ref }
Expand Down