Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create-block PHP template files according to WordPress standards #27949

Merged
merged 1 commit into from
Jan 1, 2021

Conversation

artpi
Copy link
Contributor

@artpi artpi commented Jan 1, 2021

PHP files generated by @wordpress/create-block do not follow WordPress coding guidelines.
This PR fixes phpcs errors:

 63 | ERROR   | [x] Opening parenthesis of a multi-line function call
    |         |     must be the last content on the line
 63 | ERROR   | [x] Only one argument is allowed per line in a
    |         |     multi-line function call
 67 | ERROR   | [x] Closing parenthesis of a multi-line function call
    |         |     must be on a line by itself
----------------------------------------------------------------------

Testing

  1. Create new block using the project
  2. Lint via phpcs
  3. Observe no errors

@artpi artpi requested review from gziolo and mkaz as code owners January 1, 2021 10:32
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 1, 2021
@Soean Soean added the [Type] Code Quality Issues or PRs that relate to code quality label Jan 1, 2021
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for contributing.

@Soean Soean merged commit 6cef679 into WordPress:master Jan 1, 2021
@github-actions
Copy link

github-actions bot commented Jan 1, 2021

Congratulations on your first merged pull request, @artpi! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 9.8 milestone Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants