-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the RTL editor styles and the theme styles option #27947
Merged
youknowriad
merged 1 commit into
master
from
fix/rtl-editor-styles-and-theme-styles-option
Jan 5, 2021
Merged
Fix the RTL editor styles and the theme styles option #27947
youknowriad
merged 1 commit into
master
from
fix/rtl-editor-styles-and-theme-styles-option
Jan 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
An existing feature does not function as intended
Internationalization (i18n)
Issues or PRs related to internationalization efforts
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
labels
Jan 1, 2021
youknowriad
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jan 1, 2021
I added the "backport to beta" label just so we don't forget to include this change in Core (the PHP change) |
youknowriad
force-pushed
the
fix/rtl-editor-styles-and-theme-styles-option
branch
from
January 1, 2021 09:36
6b3446b
to
ef20d94
Compare
Size Change: +8 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good! Thanks Riad 👍
Added to Core in https://core.trac.wordpress.org/ticket/52394. |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
Internationalization (i18n)
Issues or PRs related to internationalization efforts
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27937
This fixes two bugs:
Testing instructions