Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opacity 0 to for loop #27590

Closed
wants to merge 1 commit into from
Closed

Add opacity 0 to for loop #27590

wants to merge 1 commit into from

Conversation

hsingyuc
Copy link
Contributor

@hsingyuc hsingyuc commented Dec 8, 2020

Description

Fix #27495
Add opacity 0 to for loop

How has this been tested?

  1. Create a cover block image.
  2. If set opacity 0 - 4, should return class .has-background-dim-0, and opacity: 0
  3. If set opacity 5 - 14, should return class .has-background-dim-10, and opacity: 0.1
  4. If set opacity 15 - 24, should return class .has-background-dim-20, and opacity: 0.2
  5. Check if the image renders as expected.

Screenshots

test_opacity

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 8, 2020
@skorasaurus skorasaurus added the [Block] Cover Affects the Cover Block - used to display content laid over a background image label Dec 10, 2020
@gziolo gziolo removed the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 5, 2021
Base automatically changed from master to trunk March 1, 2021 15:44
@skorasaurus
Copy link
Member

Hi,

Thanks for the pull request. This has already been merged into trunk by a different PR - b5a6329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: wrong class name has-background-dim-0 with opacity 0.5
3 participants
@hsingyuc @skorasaurus @gziolo