[Mobile] Treat a string that only contains the formatting marker as empty for block formatting #27583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipsnyder
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
chipsnyder
force-pushed
the
rnmobile/2863-headingFormat
branch
from
d423a53 to
dcd7386
Compare
This was referenced Dec 8, 2020
antonis
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Great work tracking this down and resolving this @chipsnyder 👍
Tested with Android Dev to replicate the issue and confirmed that wordpress-mobile/WordPress-Android#13566 resolves it 🎉
The code LGTM!
chipsnyder
force-pushed
the
rnmobile/2863-headingFormat
branch
from
dcd7386 to
619f54b
Compare
jd-alexander
pushed a commit
that referenced
this pull request
Dec 8, 2020
…mpty for block formatting (#27583) * Treat a string that only contains the formatting marker as empty * Update changelog
3 tasks
cameronvoell
pushed a commit
that referenced
this pull request
Dec 23, 2020
* Release script: Update react-native-editor version to 1.43.0 * Release script: Update with changes from 'npm run core preios' * [Mobile] Treat a string that only contains the formatting marker as empty for block formatting (#27583) * Treat a string that only contains the formatting marker as empty * Update changelog * Mobile - Fix some cases where getBlockAttributes can be null when removing a block (#27683) * Updated CHANGELOG for release. * Removed this entry from this release since it's a hotfix. * Fix RN editor package.json indentation Co-authored-by: Chip <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]> Co-authored-by: Joel Dean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#2863
Related PRs
gutenberg-mobile: Treat a string that only contains the formatting marker as empty for block formatting wordpress-mobile/gutenberg-mobile#2877WordPress-Android (For testing): [For Testing] Treat a string that only contains the formatting marker as empty for block formatting wordpress-mobile/WordPress-Android#13566Description
When opening a post with an existing Heading Block and choosing to delete the text the block formatting would be triggered on the text that has the zero space character already applied. This would trigger an extra run of hitting delete.
How has this been tested?
Existing Block
New Heading Block
Regression test cases
Taken from wordpress-mobile/AztecEditor-Android#928
Regression test cases
Heading block
Expect to see the placeholder text return after the last character is deleted
Paragraph block
Expect to see the placeholder text return after the last character is deleted
Types of changes
Bug Fix
Checklist: