Move the templates prePersist logic to core-data #27464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Full Site Editing
[Type] Experimental
|
Size Change: -67 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/refactor-templates-saving
branch
from
e269871 to
db31e90
Compare
There was a problem hiding this comment.
This refactoring looks great, thanks for cleaning this up!
For the most part everything seems to work as expected. However, it seems when a template part moves from auto-draft to publish the title is cleared:
Where previously when they were in auto-draft status they had titles "Footer" and "Header".
|
@Addison-Stavlo Good catch, it should be fixed with a different logic than what we had on master (it actually sets a title if none is provided so you end up with capitalized slug) but it's just as good I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #26355
When saving templates whether it's from the site editor, the post editor or any editor, there's some logic that needs to run (fix titles and set the "publish" status).
Before this PR, this logic was applied in an ad-hoc way. This PR refactors it and implements a
prePersisthandler for entities and also consolidate this with some pre persist behavior we had for regular post types.