Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t split translatable strings in block templates #27361

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Don’t split translatable strings in block templates #27361

merged 2 commits into from
Nov 30, 2020

Conversation

audrasjb
Copy link
Contributor

Description

See https://core.trac.wordpress.org/ticket/51893 for full details.

How has this been tested?

No changes in the editor, see screenshot below.

Screenshots

Capture d’écran 2020-11-29 à 16 57 13

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@talldan talldan added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Nov 30, 2020
@talldan talldan changed the title WordPress 5.6: Don’t split translatable strings in block templates Don’t split translatable strings in block templates Nov 30, 2020
talldan
talldan approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the pattern still works well 👍

@talldan
Copy link
Contributor

talldan commented Nov 30, 2020

Thanks for fixing this!

@talldan talldan merged commit 5cd71f4 into WordPress:master Nov 30, 2020
@github-actions github-actions bot added this to the Gutenberg 9.5 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Milestone
Gutenberg 9.5
Development

Successfully merging this pull request may close these issues.
2 participants
@audrasjb @talldan