Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Cloud block: Adjust styles for the different block alignments #27342

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

scruffian
Copy link
Contributor

Description

This adds CSS to the tag cloud block to add some styles when the block is aligned center or full.

We could add support for padding to this block in which case we'd want to make that the default probably.

How has this been tested?

In TT1 Blocks

Screenshots

Centered
Screenshot 2020-11-27 at 18 33 13

Full width
Screenshot 2020-11-27 at 18 33 04

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link

github-actions bot commented Nov 30, 2020

Size Change: -728 B (0%)

Total Size: 1.19 MB

Filename Size Change
build/a11y/index.js 1.14 kB -1 B
build/block-directory/index.js 8.72 kB -3 B (0%)
build/block-editor/index.js 128 kB -49 B (0%)
build/block-editor/style-rtl.css 11.2 kB -55 B (0%)
build/block-editor/style.css 11.2 kB -52 B (0%)
build/block-library/editor-rtl.css 8.88 kB -66 B (0%)
build/block-library/editor.css 8.88 kB -68 B (0%)
build/block-library/index.js 148 kB +342 B (0%)
build/block-library/style-rtl.css 8.34 kB +71 B (0%)
build/block-library/style.css 8.34 kB +72 B (0%)
build/block-serialization-default-parser/index.js 1.88 kB +8 B (0%)
build/blocks/index.js 48.1 kB -6 B (0%)
build/components/index.js 172 kB +39 B (0%)
build/components/style-rtl.css 15.3 kB -8 B (0%)
build/components/style.css 15.3 kB -8 B (0%)
build/compose/index.js 9.95 kB -3 B (0%)
build/core-data/index.js 14.8 kB -3 B (0%)
build/data-controls/index.js 827 B -1 B
build/data/index.js 8.98 kB +1 B
build/date/index.js 11.2 kB -3 B (0%)
build/deprecated/index.js 768 B -1 B
build/dom/index.js 4.95 kB +1 B
build/edit-navigation/index.js 11.1 kB +13 B (0%)
build/edit-post/index.js 306 kB -17 B (0%)
build/edit-site/index.js 24.1 kB +2 B (0%)
build/edit-site/style-rtl.css 4.06 kB +156 B (3%)
build/edit-site/style.css 4.06 kB +155 B (3%)
build/edit-widgets/index.js 26.3 kB -8 B (0%)
build/editor/index.js 43.3 kB -13 B (0%)
build/element/index.js 4.63 kB +2 B (0%)
build/hooks/index.js 2.27 kB -1 B
build/html-entities/index.js 623 B +1 B
build/i18n/index.js 3.56 kB -1 B
build/keyboard-shortcuts/index.js 2.54 kB -3 B (0%)
build/media-utils/index.js 5.32 kB -2 B (0%)
build/notices/index.js 1.82 kB -2 B (0%)
build/nux/index.js 3.42 kB +1 B
build/plugins/index.js 2.56 kB +1 B
build/priority-queue/index.js 791 B +1 B
build/redux-routine/index.js 2.84 kB +3 B (0%)
build/rich-text/index.js 13.4 kB -2 B (0%)
build/server-side-render/index.js 2.77 kB -3 B (0%)
build/shortcode/index.js 1.69 kB +1 B
build/url/index.js 2.84 kB -1.22 kB (42%) 🎉
build/viewport/index.js 1.86 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/annotations/index.js 3.8 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/autop/index.js 2.84 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-library/theme-rtl.css 789 B 0 B
build/block-library/theme.css 790 B 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/dom-ready/index.js 571 B 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/style-rtl.css 6.42 kB 0 B
build/edit-post/style.css 6.4 kB 0 B
build/edit-widgets/style-rtl.css 3.13 kB 0 B
build/edit-widgets/style.css 3.13 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.86 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.1 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/primitives/index.js 1.43 kB 0 B
build/reusable-blocks/index.js 2.92 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@scruffian scruffian merged commit dda2324 into master Dec 2, 2020
@scruffian scruffian deleted the update/tag-cloud-block branch December 2, 2020 13:04
@github-actions github-actions bot added this to the Gutenberg 9.6 milestone Dec 2, 2020
@youknowriad youknowriad added the [Type] Enhancement A suggestion for improvement. label Dec 2, 2020
@youknowriad youknowriad changed the title Tag Cloud: Add CSS for block alignments Tag Cloud block: Add CSS for block alignments Dec 2, 2020
@youknowriad youknowriad changed the title Tag Cloud block: Add CSS for block alignments Tag Cloud block: Adjust styles for the different block alignments Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Tag Cloud Affects the Tag Cloud Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants