Simplify CSS for the code block #27314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Block] Code
scruffian
force-pushed
the
update/code-block-css
branch
from
ed41acd to
d92ae49
Compare
|
Size Change: -10 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
I'm always careful when we make a change to the style.scss of a core block. They affect every instance of the block in use, so we should move carefully.
In this case, however, the change seems good and obvious. I'll CC: @kjellr so when he's back he can sanity check whether we need to rewind this PR, but in the mean time, cool PR!
aristath
approved these changes
Nov 27, 2020
|
Thanks @aristath I was also worried about that, which is why I made a PR just for this one change! |
ZebulanStanphill
added
[Package] Block library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the
display: block;rule to the front end, so that the frontend and backend match.The HTML spec indicates that when a code element is used inside a pre element it represents a block of code, so I think this CSS fits with that approach.
How has this been tested?
Tested in TwentyTwentyOne where this line came from
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: