[Mobile] Copy/Paste improvement #27242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: -983 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Tug
reviewed
Dec 21, 2020
added 2 commits
December 29, 2020 15:43
# Conflicts: # packages/block-editor/src/components/inserter/menu.native.js
geriux
force-pushed
the
rnmobile/refactor-notices-copy-paste
branch
from
59c3f87 to
b71e852
Compare
Tug
reviewed
Dec 29, 2020
packages/block-editor/src/components/block-mobile-toolbar/block-actions-menu.native.js
Outdated
Show resolved
Hide resolved
added 2 commits
December 30, 2020 10:12
… comment to explain getItems in the inserter menu
…e to handle clipboard change
Tug
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
Clipboardcontext instead of using thecore/editorstore, I ended up not using the actual clipboard of the device for now because the current implementation checks the clipboard when trying to add a new block or opening the toolbar options, this on iOS wouldn't be a good approach since you'll see a prompt notice about using the device clipboard:It also changes how the
Noticecomponent stores its data, it was using thecore/editorstore but now it'll usecore/notices.These changes are in favor of the issue with dependencies in the
InserterandBlockMobileToolbar.How has this been tested?
Steps to test
Copy / Paste after block
Cut block
Duplicate block
For the above actions make sure:
Screenshots
N/A
Types of changes
Checklist: