Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace adminbar customize link with site-editor in FSE themes #27135

Merged
merged 6 commits into from
Nov 23, 2020

Conversation

aristath
Copy link
Member

Description

Replaces the "Customize" link with "Edit site".

This is only for FSE themes on the frontend.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that the other day, I'm sure there is more to tweak 👍

@github-actions
Copy link

github-actions bot commented Nov 20, 2020

Size Change: +3.02 kB (0%)

Total Size: 1.2 MB

Filename Size Change
build/annotations/index.js 3.8 kB +1 B
build/autop/index.js 2.83 kB -2 B (0%)
build/blob/index.js 665 B +1 B
build/block-directory/index.js 8.72 kB -2 B (0%)
build/block-editor/index.js 133 kB +22 B (0%)
build/block-library/editor-rtl.css 8.96 kB +10 B (0%)
build/block-library/editor.css 8.96 kB +10 B (0%)
build/block-library/index.js 148 kB +498 B (0%)
build/block-library/style-rtl.css 8.23 kB +123 B (1%)
build/block-library/style.css 8.23 kB +123 B (1%)
build/blocks/index.js 48.1 kB +76 B (0%)
build/components/index.js 172 kB -13 B (0%)
build/compose/index.js 9.93 kB -19 B (0%)
build/core-data/index.js 14.8 kB +2 B (0%)
build/data/index.js 9.71 kB +915 B (9%) 🔍
build/date/index.js 11.2 kB +2 B (0%)
build/deprecated/index.js 769 B +1 B
build/dom/index.js 4.92 kB +1 B
build/edit-navigation/index.js 11.2 kB -6 B (0%)
build/edit-post/index.js 306 kB -9 B (0%)
build/edit-site/index.js 23.5 kB +295 B (1%)
build/edit-site/style-rtl.css 3.86 kB +11 B (0%)
build/edit-site/style.css 3.86 kB +11 B (0%)
build/edit-widgets/index.js 26.4 kB +3 B (0%)
build/editor/index.js 43.3 kB +653 B (1%)
build/format-library/index.js 6.86 kB -4 B (0%)
build/i18n/index.js 3.57 kB +1 B
build/keyboard-shortcuts/index.js 2.85 kB +311 B (10%) ⚠️
build/keycodes/index.js 1.94 kB +1 B
build/media-utils/index.js 5.31 kB -3 B (0%)
build/notices/index.js 1.82 kB +1 B
build/nux/index.js 3.42 kB +1 B
build/plugins/index.js 2.56 kB +1 B
build/primitives/index.js 1.43 kB -1 B
build/redux-routine/index.js 2.84 kB +2 B (0%)
build/reusable-blocks/index.js 3.07 kB +1 B
build/rich-text/index.js 13.4 kB +3 B (0%)
build/server-side-render/index.js 2.77 kB -1 B
build/shortcode/index.js 1.69 kB -1 B
build/viewport/index.js 1.86 kB -2 B (0%)
build/warning/index.js 1.14 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11.3 kB 0 B
build/block-editor/style.css 11.3 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/data-controls/index.js 827 B 0 B
build/dom-ready/index.js 571 B 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/style-rtl.css 6.45 kB 0 B
build/edit-post/style.css 6.44 kB 0 B
build/edit-widgets/style-rtl.css 3.13 kB 0 B
build/edit-widgets/style.css 3.13 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.62 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.16 kB 0 B
build/html-entities/index.js 623 B 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/list-reusable-blocks/index.js 3.1 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/priority-queue/index.js 790 B 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.05 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

lib/full-site-editing.php Outdated Show resolved Hide resolved
@gziolo gziolo added the General Interface Parts of the UI which don't fall neatly under other labels. label Nov 20, 2020
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior proposed doesn't differ much from how the item in the sidebar is exposed:

gutenberg/gutenberg.php

Lines 105 to 118 in 1862c62

if ( gutenberg_is_fse_theme() ) {
add_menu_page(
__( 'Site Editor (beta)', 'gutenberg' ),
sprintf(
/* translators: %s: "beta" label. */
__( 'Site Editor %s', 'gutenberg' ),
'<span class="awaiting-mod">' . __( 'beta', 'gutenberg' ) . '</span>'
),
'edit_theme_options',
'gutenberg-edit-site',
'gutenberg_edit_site_page',
'dashicons-layout'
);
}

As a follow-up, we should limit this option based on user permissions.

Edit: Actually, there is an existing check for edit_theme_options capability, should we guard this link the same way?

@aristath
Copy link
Member Author

Edit: Actually, there is an existing check for edit_theme_options capability, should we guard this link the same way?

Good point. Added in e1cdbee 👍

@aristath aristath merged commit 5a90a57 into master Nov 23, 2020
@aristath aristath deleted the remove/adminbar-customize branch November 23, 2020 07:00
@github-actions github-actions bot added this to the Gutenberg 9.5 milestone Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants