Full Site Editing: Add the theme source to the templates wp-admin list #27108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
requested review from
mattwiebe,
vindl,
david-szabo97,
jeyip,
noahtallen and
Addison-Stavlo
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
david-szabo97
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Code-wise LGTM and works well on local!
The current (Created from a template file) label is a placeholder intended to start a discussion.
I think this makes sense. As a user it might be confusing to see several templates created without ever doing anything. (For example on theme activation) This would give enough information for the users to understand what's happening.
|
The failing lint check is just from an outdated package-lock, so i think it needs to be rebased |
Copons
force-pushed
the
update/templates-wp-admin-list-theme
branch
from
17a3592 to
277b4f4
Compare
|
Super useful for debugging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently added a
wp_themetaxonomy to templates that keeps track of the theme to which a template belongs to, and whether it was originally created from a file.This PR simply adds a new column to the templates wp-admin list that shows the theme name (or its slug if the theme is not installed on the site anymore), and a message to clarify that it originated as a file.
Note
I don't have a good idea regarding the "file based" label.
The current
(Created from a template file)label is a placeholder intended to start a discussion.How has this been tested?
Try activating different FSE themes, let them generate template posts from the provided files.
Open
/wp-admin/edit.php?post_type=wp_template.Check the Theme column, and make sure it displays the correct informations.
Try creating a custom template from scratch, and make sure it's not labeled as "file based".
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: