Global Styles: keep core and theme preset variables and classes even if they are overwritten #27082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
Global Styles
jorgefilipecosta
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +173 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
Base automatically changed from
add/lodash-set-equivalent-to-php-utils
to
master
November 20, 2020 19:01
Squashed commits: [0ef9982] Global Styles: Keep core and theme preset classes and variables even if they are overwritten.
jorgefilipecosta
force-pushed
the
update/keep-core-and-theme-preset-variables-and-classes-even-if-they-are-overwritten
branch
from
a763bd4 to
a2040a3
Compare
|
👋 I've been looking at the current state of how user-provided colors work and this PR. What if we made this work this way:
What do you think? I'm not convinced allowing users to remove theme colors is a good thing. It sets false expectations that we can't really control (that color is not used) and comes with some conceptual&implementation complexity I don't think we need at the moment. |
oandregal
reviewed
Nov 23, 2020
| @@ -177,7 +177,7 @@ class WP_Theme_JSON { | |||
| */ | |||
| const PRESETS_METADATA = array( | |||
| array( | |||
| 'path' => array( 'settings', 'color', 'palette' ), | |||
There was a problem hiding this comment.
I think we already discussed this? I may be dreaming, though 😅 so I'm going to list why I don't think this is a good idea:
- it forces all the code that processes the presets to hold a partial reference to its path (
settings), which they shouldn't need to. - we can't automate updating the docs from this info without also holding a reference to
settings - a reader of the code can't know where these are sourced from without looking at how they're processed
There was a problem hiding this comment.
Hi @nosolosw,
I applied this change here because as part of this PR I needed to retrieve and set presets from deactivatedSettings instead of from settings.
gutenberg_experimental_set(
$this->contexts[ $context ]['deactivatedSettings'],
$preset['path'],
There was a problem hiding this comment.
With the caveat that I'm not sure this should work this way, as I mentioned below, I also wanted to share that perhaps is a way to balance both needs?
oandregal
deleted the
update/keep-core-and-theme-preset-variables-and-classes-even-if-they-are-overwritten
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #27077
This PR makes sure core and global styles preset variables and classes are kept even if they are overwritten.
Users may change or delete the presets, and the UI (e.g: color palette) should reflect that. But if the theme is using the preset variable in other place we should not break the theme and should still have the variable present. This PR makes sure the variables and classes are always present.
How has this been tested?
I added the 2021 blocks theme.
I deleted the preset background color.
I verified the background color was still applied,