Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus outside: rewrite as hook and remove wrapper div in Popover #27050

Closed
wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

Description

This is a good improvement by itself because it allows you to avoid a wrapper div. It's especially useful for the Popover because I'd like to make some performance improvements with using sticky position for the block toolbar. Sticky positioning is only possible when the element is a direct child of the scroll container.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ellatrix ellatrix added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 17, 2020
@github-actions
Copy link

Size Change: -239 B (0%)

Total Size: 1.19 MB

Filename Size Change
build/annotations/index.js 3.77 kB +3 B (0%)
build/autop/index.js 2.83 kB -1 B
build/block-directory/index.js 8.71 kB +3 B (0%)
build/block-library/index.js 147 kB -2 B (0%)
build/block-serialization-default-parser/index.js 1.87 kB -1 B
build/blocks/index.js 48 kB -2 B (0%)
build/components/index.js 171 kB -242 B (0%)
build/compose/index.js 9.95 kB +2 B (0%)
build/dom/index.js 4.92 kB -1 B
build/edit-navigation/index.js 11.1 kB -1 B
build/edit-post/index.js 306 kB +1 B
build/edit-site/index.js 23.3 kB +3 B (0%)
build/edit-widgets/index.js 26.3 kB -1 B
build/editor/index.js 42.5 kB -1 B
build/element/index.js 4.62 kB +3 B (0%)
build/format-library/index.js 6.86 kB +2 B (0%)
build/hooks/index.js 2.16 kB -1 B
build/keyboard-shortcuts/index.js 2.52 kB -2 B (0%)
build/keycodes/index.js 1.93 kB -1 B
build/list-reusable-blocks/index.js 3.1 kB +1 B
build/nux/index.js 3.4 kB +2 B (0%)
build/plugins/index.js 2.56 kB +1 B
build/rich-text/index.js 13.3 kB -1 B
build/server-side-render/index.js 2.77 kB -2 B (0%)
build/token-list/index.js 1.27 kB +1 B
build/viewport/index.js 1.84 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/blob/index.js 664 B 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 133 kB 0 B
build/block-editor/style-rtl.css 11.3 kB 0 B
build/block-editor/style.css 11.3 kB 0 B
build/block-library/editor-rtl.css 8.91 kB 0 B
build/block-library/editor.css 8.92 kB 0 B
build/block-library/style-rtl.css 8.1 kB 0 B
build/block-library/style.css 8.1 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/core-data/index.js 14.8 kB 0 B
build/data-controls/index.js 827 B 0 B
build/data/index.js 8.74 kB 0 B
build/date/index.js 11.2 kB 0 B
build/deprecated/index.js 768 B 0 B
build/dom-ready/index.js 571 B 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/style-rtl.css 6.51 kB 0 B
build/edit-post/style.css 6.49 kB 0 B
build/edit-site/style-rtl.css 3.98 kB 0 B
build/edit-site/style.css 3.98 kB 0 B
build/edit-widgets/style-rtl.css 3.16 kB 0 B
build/edit-widgets/style.css 3.16 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/reusable-blocks/index.js 3.05 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/url/index.js 4.05 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@ellatrix ellatrix closed this Dec 7, 2020
@ellatrix ellatrix deleted the try/use-focus-outside branch December 7, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant