Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/image block reset sizes on external url change #26879

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Fix/image block reset sizes on external url change #26879

merged 3 commits into from
Mar 22, 2021

Conversation

daddou-ma
Copy link
Contributor

closes #26333

Description

Image Block: reset dimensions on replacing a resized image by external URL. more details #26333.

How has this been tested?

Screenshots

fix

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@daddou-ma daddou-ma mentioned this pull request Nov 11, 2020
Closed
@ellatrix
Copy link
Member

Nice! Could you make a simple e2e test case to make sure it doesn't regress?

@daddou-ma
Copy link
Contributor Author

Nice! Could you make a simple e2e test case to make sure it doesn't regress?

Yes, of course.

@daddou-ma daddou-ma force-pushed the fix/image-block-reset-sizes-on-external-url-change branch from d4b9d60 to 3dc41b0 Compare November 13, 2020 19:35
@daddou-ma
Copy link
Contributor Author

Nice! Could you make a simple e2e test case to make sure it doesn't regress?

@ellatrix, I added a e2e test for this case in 3dc41b0423f33c4bbe4c79a62949639bd7c23f88.

ellatrix
ellatrix approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a rebase.

@daddou-ma daddou-ma force-pushed the fix/image-block-reset-sizes-on-external-url-change branch from 3dc41b0 to fca3710 Compare January 27, 2021 13:46
@daddou-ma
Copy link
Contributor Author

Just needs a rebase.

@ellatrix PR rebased.

Base automatically changed from master to trunk March 1, 2021 15:44
@ellatrix
Copy link
Member

ellatrix commented Mar 9, 2021

Not sure why the tests are failing and I can't restart them. Would it be possible to rebase again onto trunk?

@daddou-ma daddou-ma force-pushed the fix/image-block-reset-sizes-on-external-url-change branch from fca3710 to 58d38b7 Compare March 20, 2021 23:56
@daddou-ma
Copy link
Contributor Author

Not sure why the tests are failing and I can't restart them. Would it be possible to rebase again onto trunk?

Sorry for being late @ellatrix. I did it.

@ellatrix ellatrix merged commit 2cc9a1b into WordPress:trunk Mar 22, 2021
@github-actions github-actions bot added this to the Gutenberg 10.3 milestone Mar 22, 2021
@gziolo gziolo mentioned this pull request Apr 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ajlende ajlende Awaiting requested review from ajlende

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 10.3
Development

Successfully merging this pull request may close these issues.

Image Block: Replacing a resized image from URL doesn't reset dimensions
2 participants
@daddou-ma @ellatrix