Switch back to getAuthors

packages/core-data/src/resolvers.js

@@ -29,14 +29,29 @@ import { ifNotResolved, getNormalizedCommaSeparable } from './utils';
 
 /**
  * Requests authors from the REST API.
+ *
+ * @param {Object|undefined} query Optional object of query parameters to
+ *                                 include with request.
  */
-export function* getAuthors() {
+export function* getAuthors( query ) {
 	const users = yield apiFetch( {
-		path: '/wp/v2/users/?who=authors&per_page=-1',
+		path: addQueryArgs( '/wp/v2/users/?who=authors&per_page=100', query ),
 	} );
 	yield receiveUserQuery( 'authors', users );
 }
 
+/**
+ * Temporary approach to resolving editor access to author queries.
+ *
+ * @param {number} id The author id.
+ */
+export function* __unstableGetAuthor( id ) {
+	const users = yield apiFetch( {
+		path: `/wp/v2/users?who=authors&include=${ id }`,
+	} );
+	yield receiveUserQuery( 'author', users );
+}
+
 /**
  * Requests the current user from the REST API.
  */

packages/core-data/src/selectors.js

@@ -56,12 +56,21 @@ export const isRequestingEmbedPreview = createRegistrySelector(
  * @return {Array} Authors list.
  */
 export function getAuthors( state ) {
-	deprecated( "select( 'core' ).getAuthors()", {
-		alternative: "select( 'core' ).getUsers({ who: 'authors' })",
-	} );
 	return getUserQueryResults( state, 'authors' );
 }
 
+/**
+ * Returns all available authors.
+ *
+ * @param {Object} state Data state.
+ *
+ * @return {Array} Authors list.
+ */
+export function __unstableGetAuthor( state ) {
+	const authors = getUserQueryResults( state, 'author' );
+	return authors ? authors[ 0 ] : [];
+}
+
 /**
  * Returns the current user.
  *

packages/editor/src/components/post-author/check.js

@@ -8,6 +8,7 @@ import { get } from 'lodash';
  */
 import { withInstanceId, compose } from '@wordpress/compose';
 import { withSelect } from '@wordpress/data';
+import { useMemo } from '@wordpress/element';
 
 /**
  * Internal dependencies
@@ -18,8 +19,13 @@ export function PostAuthorCheck( {
 	hasAssignAuthorAction,
 	authors,
 	children,
+	post,
 } ) {
-	if ( ! hasAssignAuthorAction || ! authors || authors.length < 2 ) {
+	const initialAuthors = useMemo( () => {
+		return authors;
+	}, [ post ] );
+
+	if ( ! hasAssignAuthorAction || ! authors || 1 >= initialAuthors.length ) {
 		return null;
 	}
 
@@ -40,7 +46,8 @@ export default compose( [
 				false
 			),
 			postType: select( 'core/editor' ).getCurrentPostType(),
-			authors: select( 'core' ).getUsers( { who: 'authors' } ),
+			authors: select( 'core' ).getAuthors(),
+			post,
 		};
 	} ),
 	withInstanceId,

packages/editor/src/components/post-author/index.js

@@ -21,17 +21,23 @@ function PostAuthor() {
 
 	const { authorId, isLoading, authors, postAuthor } = useSelect(
 		( select ) => {
-			const { getUser, getUsers, isResolving } = select( 'core' );
+			const { __unstableGetAuthor, getAuthors, isResolving } = select(
+				'core'
+			);
 			const { getEditedPostAttribute } = select( 'core/editor' );
-			const author = getUser( getEditedPostAttribute( 'author' ) );
+			const author =
+				postAuthor ||
+				__unstableGetAuthor( getEditedPostAttribute( 'author' ) );
 			const query =
-				! fieldValue || '' === fieldValue ? {} : { search: fieldValue };
+				! fieldValue || '' === fieldValue || fieldValue === author.name
+					? {}
+					: { search: fieldValue };
 			return {
 				authorId: getEditedPostAttribute( 'author' ),
 				postAuthor: author,
-				authors: getUsers( { who: 'authors', ...query } ),
-				isLoading: isResolving( 'core', 'getUsers', [
-					{ search: fieldValue, who: 'authors' },
+				authors: getAuthors( query ),
+				isLoading: isResolving( 'core', 'getAuthors', [
+					{ search: fieldValue },
 				] ),
 			};
 		},