Cleanup PHP Codesniffer warnings and enable fail #26516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
mkaz
force-pushed
the
fix/26490-warnings
branch
from
74146b1 to
08aac8e
Compare
mkaz
force-pushed
the
fix/26490-warnings
branch
2 times, most recently
from
f4b2cc7 to
93b80d7
Compare
mkaz
force-pushed
the
fix/26490-warnings
branch
from
93b80d7 to
d0f2d74
Compare
- Removes flag ignore warnings in composer.json - Fixes Unused variable warnings Most cases were: `foreach ( $some_array as $key => $value )` with the $key value not being used. If ommited the foreach will just set the value and ignore the key.
mkaz
changed the title
gziolo
added
the
Gutenberg Plugin
aristath
approved these changes
Jun 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #26472 a flag was added to the lint command to not fail on warnings, it was failing on instances of Unused Variables.
This PR fixes the unused variables in the code and removes flag
Closes #26490
How has this been tested?
Setup:
composer installBaseline:
npm run lint-php, confirm warningsConfirm:
npm run lint-phpIf you are not running Docker, you can call:
./vendor/squizlabs/php_codesniffer/bin/phpcs --standard=phpcs.xml.distTypes of changes