Consolidate sequential multi-entity-saving tests. #26373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
Addison-Stavlo
requested review from
youknowriad,
vindl,
mattwiebe,
noahtallen,
Copons,
david-szabo97 and
jeyip
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
jeyip
approved these changes
Oct 22, 2020
|
Link to core editor thread for context https://wordpress.slack.com/archives/C02QB2JS7/p1603273692298300 |
|
what if we also added |
Interesting. I wonder if that makes sense here? In the example it is used to ensure assertions within passed callbacks actually happen, but here we aren't passing any assertions as callbacks but are just calling the assertions themselves? |
|
good point! I don't really mind; I've just seen it in a few places and thought it might fit |
Addison-Stavlo
force-pushed
the
fix/sequential-multi-entity-saving-tests
branch
from
9f40f72 to
1cc35c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussions in core slack with @talldan and @youknowriad pointed out sequential tests can be problematic. This PR consolidates multi-entity-saving tests that are dependent on each others steps into the same test blocks.
How has this been tested?
Screenshots
Types of changes
Checklist: