Button: Fix position of the link input field #2636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes #2635 so the position of the URL input field is in the window
|
pinging @mtias as the original author of the button block. With this PR the link input is not centered anymore. An alternative would be to use a higher zindex than the WP sidebar (for all popovers), but I think some people were against this in another PR. Can't recall the reasons. |
|
@youknowriad The zindex fix doesn't work for mobile |
|
I think we need a robust solution for this as it's been something that's worked/doesn't work. It's all part of a better mobile approach to me - which we need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2635 so the position of the URL input field is in the window