Heading block: add wide and full width options #25917
Conversation
oandregal
changed the title
oandregal
added
the
[Feature] Design Tools
|
Size Change: +9 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
When testing this PR, I'm not seeing these options available in the toolbar:
|
|
🤔 it works fine for me
|
oandregal
force-pushed
the
try/heading-align-support
branch
from
b2225b6 to
26745e5
Compare
|
Rebased and pushed to fix the e2e tests (a fix was recently merged for them). |
|
A couple of quick thoughts. First off, this is a good update, as it enables some layouts that are currently arbitrarily limited. Especially if when a fullwide group block creates a centered column inside by default (just like post content), allowing these widths enables designs that were otherwise off-limits. In fact it begs the question if not all (or the majority) of blocks should enable these width buttons. For starters, perhaps, #25080 and #25147 would be good to address. However it also brings up the question of where the control should live. For the heading block, it barely fits on small screens:
The separator block will be fine. But if we are to bring this to all blocks (in future explorations), we can't actually put it in the toolbar for all of them. For a list block, it just won't fit. We could put in the sidebar as we have in the past for some blocks. So as we add these controls to more blocks, it would be good to think about a basic heuristic for when it goes in the block toolbar, vs. a sidebar. One basic version would be: if it's a primary action, put it in the toolbar. The question then is, whether it's a primary action for the heading block — I'm not sure. That's not to hold up this PR — just that, maybe we want to move it to the sidebar in the future, as part of expanding these controls to more blocks. |
|
@nosolosw Great! A useful addition would be to add these options to the paragraph block. As the paragraph supports large font sizes, it can be useful for some layouts. For example, here's a screenshot of a page designed by @melchoyce from the Twenty Twenty One Figma. For the moment, it's not possible to achieve this layout.
|
|
@nosolosw The options aren’t in the same order as for all the other blocks: Wide width should be before Full width.
|
|
Thanks for reporting, Diane! I wasn't aware that set the order for the controls. Fix at #26260 |
Fixes #25655