Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Simplify media insertion flow #25031

Closed
wants to merge 70 commits into from
Closed

[RNMobile] Simplify media insertion flow #25031

wants to merge 70 commits into from

Commits on Sep 2, 2020

  1. automatically open the media options bottom sheet

    @jd-alexander
    jd-alexander committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    67c84d9 View commit details
    Browse the repository at this point in the history

  2. remove the image if the cancel option is selected.

    @jd-alexander
    jd-alexander committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    e8940fd View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. added the clear media option.

    @jd-alexander
    jd-alexander committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    d795232 View commit details
    Browse the repository at this point in the history

  2. fixed the order of the cancel button.

    @jd-alexander
    jd-alexander committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    3c29025 View commit details
    Browse the repository at this point in the history

  3. put a newline to separate cancellation if logic from the code below

    @jd-alexander
    jd-alexander committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    0bc20d7 View commit details
    Browse the repository at this point in the history

  4. made variable names more meaningful.

    @jd-alexander
    jd-alexander committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    9f3269b View commit details
    Browse the repository at this point in the history

  5. shared the destructiveButton logic between the Image & Cover block.

    @jd-alexander
    jd-alexander committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    7de89e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Merge branch 'master' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    d488ba8 View commit details
    Browse the repository at this point in the history

  2. merging resolved conflicts.

    @jd-alexander
    jd-alexander committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    8163ce6 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. reverted the Image Editing Button behavior to having the ability to p… 

    …ass in the pickerOptions
    @jd-alexander
    jd-alexander committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    6a9d981 View commit details
    Browse the repository at this point in the history

  2. Reverted changes to the ImageComponent and passed in the Clear Media … 

    …behavior from the Image Block itself.
    @jd-alexander
    jd-alexander committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    3de9cf0 View commit details
    Browse the repository at this point in the history

  3. remove the delete behavior from the image block.

    @jd-alexander
    jd-alexander committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    59c36db View commit details
    Browse the repository at this point in the history

  4. Utilize a delay on iOS so that the inserter being closed doesn't dism… 

    …iss the picker when it's being presented.
    @jd-alexander
    jd-alexander committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    3cdde20 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary line.

    @jd-alexander
    jd-alexander committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    60a3feb View commit details
    Browse the repository at this point in the history

  6. put the mediaPickerOptions back in the correct location to eliminate … 

    …unneeded diff.
    @jd-alexander
    jd-alexander committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    8966c23 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. pass the autoOpenMediaUpload flag to the MediaUpload component so it … 

    …handles all the logic for the auto-opening.
    @jd-alexander
    jd-alexander committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    0bfe3d6 View commit details
    Browse the repository at this point in the history

  2. moved delaying logic to the MediaUpload onPickerPresent function.

    @jd-alexander
    jd-alexander committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    f72c3ae View commit details
    Browse the repository at this point in the history

  3. Once the media is cleared then the picker should not be shown.

    @jd-alexander
    jd-alexander committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    0ce172c View commit details
    Browse the repository at this point in the history

  4. removed unneeded MEDIA_UPLOAD_CANCEL type

    @jd-alexander
    jd-alexander committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    e608165 View commit details
    Browse the repository at this point in the history

  5. revert changes made to the Cover block with onClearMedia logic.

    @jd-alexander
    jd-alexander committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    c104069 View commit details
    Browse the repository at this point in the history

  6. removed unneeded variable for autoOpenMediaUpload

    @jd-alexander
    jd-alexander committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    0628c3f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. added auto open to the Video block.

    @jd-alexander
    jd-alexander committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    4148aca View commit details
    Browse the repository at this point in the history

  2. added the auto open to the Image Gallery block.

    @jd-alexander
    jd-alexander committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    cb8f9e0 View commit details
    Browse the repository at this point in the history

  3. removed unneeded state and passed the auto open logic as an expression.

    @jd-alexander
    jd-alexander committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    ff3e869 View commit details
    Browse the repository at this point in the history

  4. paused auto open logic as an expression to autoOpenMediaUpload.

    @jd-alexander
    jd-alexander committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    3016466 View commit details
    Browse the repository at this point in the history

  5. added a comment about why the delay is necessary on iOS.

    @jd-alexander
    jd-alexander committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    af882b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. attempt at fixing tests.

    @jd-alexander
    jd-alexander committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    07cea7b View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Changed the iOS Picker's termination action text from Cancel to Dismiss.

    @jd-alexander
    jd-alexander committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    7ad8fc8 View commit details
    Browse the repository at this point in the history

  2. changed button accessibility id from Cancel to Dismiss.

    @jd-alexander
    jd-alexander committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    3f113a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Merge branch 'master' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    23dc6fe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    372306f View commit details
    Browse the repository at this point in the history

  3. use driver.sleep( 1000 ) to ensure that the bottom sheet is visible.

    @jd-alexander
    jd-alexander committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    f217d4a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. Merge branch 'master' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    e598262 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    e3d3eeb View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Merge branch 'master' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    96d6b7a View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. The Undo and clearMedia buttons do not trigger the media upload picker

    @jd-alexander
    jd-alexander committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    1b9656b View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. bottom sheet is not triggered for undo operations on the video block.

    @jd-alexander
    jd-alexander committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    653b416 View commit details
    Browse the repository at this point in the history

  2. bottom sheet is not triggered for clear or undo gallery operations

    @jd-alexander
    jd-alexander committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    252c74e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    458499a View commit details
    Browse the repository at this point in the history

  4. converted behavior to utilize hooks in the gallery component.

    @jd-alexander
    jd-alexander committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    4691407 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. added actions for the block insertion events.

    @jd-alexander
    jd-alexander committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    ae0c58c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Updated actions, reducer and selectors to support block inserted.

    @jd-alexander
    jd-alexander committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    7b49207 View commit details
    Browse the repository at this point in the history

  2. added block insertion event to menu.

    @jd-alexander
    jd-alexander committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    6cf07a6 View commit details
    Browse the repository at this point in the history

  3. Added wasBlockJustInserted to utilize it to open the bottom sheet.

    @jd-alexander
    jd-alexander committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    206a83f View commit details
    Browse the repository at this point in the history

  4. Removed already opened logic and bound the wasBlockJustInserted

    @jd-alexander
    jd-alexander committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    d3cfdfa View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. simplified redux approach for auto opening.

    @jd-alexander
    jd-alexander committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    2fcaaab View commit details
    Browse the repository at this point in the history

  2. removed unneeded true comparison

    @jd-alexander
    jd-alexander committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    350aef7 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2020

  1. renamed the behavior from blockInsertionEvent to lastBlockInserted

    @jd-alexander
    jd-alexander committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    043a9b6 View commit details
    Browse the repository at this point in the history

  2. added the wasBlockJustInserted call to the Image block.

    @jd-alexander
    jd-alexander committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    20e79e4 View commit details
    Browse the repository at this point in the history

  3. added wasBlockJustInserted functionality to the Gallery flow.

    @jd-alexander
    jd-alexander committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    2fec1cc View commit details
    Browse the repository at this point in the history

  4. added wasBlockJustInserted to the Video component.

    @jd-alexander
    jd-alexander committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    e396965 View commit details
    Browse the repository at this point in the history

  5. Updated the comment so it's more meaningful.

    @jd-alexander
    jd-alexander committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    397b79f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    ef86342 View commit details
    Browse the repository at this point in the history

  7. improved the comment of the lastBlockInserted selector

    @jd-alexander
    jd-alexander committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    cb7aeaf View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Update packages/editor/src/store/selectors.native.js 

    Co-authored-by: Paul Von Schrottky <[email protected]>
    @jd-alexander @guarani
    jd-alexander and guarani authored Nov 17, 2020
    Configuration menu
    Copy the full SHA
    6afbaf8 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Merge branch 'master' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    f114df8 View commit details
    Browse the repository at this point in the history

  2. fixed issues that arose during the merge.

    @jd-alexander
    jd-alexander committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    35b703b View commit details
    Browse the repository at this point in the history

  3. removed optimist block from reducer combination.

    @jd-alexander
    jd-alexander committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    fd49e34 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    d56673f View commit details
    Browse the repository at this point in the history

  5. Utilized the useDispatch hook approach for last block inserted.

    @jd-alexander
    jd-alexander committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    f76fd03 View commit details
    Browse the repository at this point in the history

  6. fixed lint errors.

    @jd-alexander
    jd-alexander committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    fd0e7dd View commit details
    Browse the repository at this point in the history

  7. Utilized editorPage.driver instead of driver reference.

    @jd-alexander
    jd-alexander committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    c1c0087 View commit details
    Browse the repository at this point in the history

  8. added unit tests for the selectors.

    @jd-alexander
    jd-alexander committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    fb4d162 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. renamed the title of test group to match with tests within the store

    @jd-alexander
    jd-alexander committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    21ce189 View commit details
    Browse the repository at this point in the history

  2. removed unneeded client from CLEAR_LAST_BLOCK_INSERTED

    @jd-alexander
    jd-alexander committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    91556bc View commit details
    Browse the repository at this point in the history

  3. added unit tests for the actions and reducers of the last block inserted

    @jd-alexander
    jd-alexander committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    7030c9d View commit details
    Browse the repository at this point in the history

  4. made test values simpler.

    @jd-alexander
    jd-alexander committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    f664f27 View commit details
    Browse the repository at this point in the history

  5. added documentation for changes to the MediaPlaceholder component.

    @jd-alexander
    jd-alexander committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    d0a8610 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'trunk' into rnmobile/simplify_image_insertion_flow

    @jd-alexander
    jd-alexander committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    e23f7df View commit details
    Browse the repository at this point in the history

  7. updated MediaUpload and MediaPlaceholder documentation.

    @jd-alexander
    jd-alexander committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    ca7eee3 View commit details
    Browse the repository at this point in the history