FIX: Links: Can't add plain text after insert link at end of paragraph #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Aug 21, 2017
| function isLinkBoundary( fragment ) { | ||
| return fragment.childNodes && fragment.childNodes.length === 1 && | ||
| fragment.childNodes[ 0 ].nodeName === 'A' && fragment.childNodes[ 0 ].text.length === 1 && | ||
| fragment.childNodes[ 0 ].text[ 0 ] === '\uFEFF'; |
There was a problem hiding this comment.
It's fine for now, but maybe this character could be included in a constant somewhere in TinyMCE to avoid issues if it's changed.
There was a problem hiding this comment.
@youknowriad there's a function in TinyMCE we can look at exposing
youknowriad
approved these changes
Aug 21, 2017
Codecov Report
@@ Coverage Diff @@
## master #2483 +/- ##
==========================================
- Coverage 26.93% 26.92% -0.01%
==========================================
Files 158 158
Lines 4897 4898 +1
Branches 814 816 +2
==========================================
Hits 1319 1319
+ Misses 3035 3034 -1
- Partials 543 545 +2
Continue to review full report at Codecov.
|
|
@youknowriad at the moment you need to right arrow after the link to escape it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1246