Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all px values in front-facing styles to relative (em) units #24523

Merged
merged 38 commits into from
Aug 28, 2020
Merged

Convert all px values in front-facing styles to relative (em) units #24523

merged 38 commits into from
Aug 28, 2020

Commits on Aug 3, 2020

  1. Merge pull request #1 from WordPress/master

    @aristath
    aristath authored Aug 3, 2020
    Configuration menu
    Copy the full SHA
    0ff3380 View commit details
    Browse the repository at this point in the history

  2. Button Block: Use relative instead of absolute units

    @aristath
    aristath committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    db8ca29 View commit details
    Browse the repository at this point in the history

  3. Use relative units for calendar paddings

    @aristath
    aristath committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    20e96a5 View commit details
    Browse the repository at this point in the history

  4. Paragraph block: Use relative instead of absolute units

    @aristath
    aristath committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    47efef0 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. Text Columns: Prefer relative units

    @aristath
    aristath committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    3eb326a View commit details
    Browse the repository at this point in the history

  2. Quote block: Prefer relative units

    @aristath
    aristath committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    b204bf8 View commit details
    Browse the repository at this point in the history

  3. Pullquote block: Prefer relative units

    @aristath
    aristath committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    7ae267a View commit details
    Browse the repository at this point in the history

  4. also apply changes to native

    @aristath
    aristath committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    519dae7 View commit details
    Browse the repository at this point in the history

  5. Latest Comments Block: Prefer relative units

    @aristath
    aristath committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    8ee37dd View commit details
    Browse the repository at this point in the history

  6. Use relative units for social-icons block

    @aristath
    aristath committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    d6ba20f View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. Don't use $grid-unit-* vars for front-facing styles

    @aristath
    aristath committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    992c777 View commit details
    Browse the repository at this point in the history

  2. Avoid using $default-block-margin for front-facing styles

    @aristath
    aristath committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    8ac774f View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Merge branch 'aristath/no-front-default-block-margin' into aristath/t… 

    …ry-relative-units
    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    e7dac0d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'aristath/no-front-grid-vars' into aristath/try-relative… 

    …-units
    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    a1d6b2d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'aristath/text-columns-relative-units' into aristath/try… 

    …-relative-units
    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    187a50a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'aristath/social-icons-relative-units' into aristath/try… 

    …-relative-units
    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    df93076 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'aristath/pullquote-block-relative-units' into aristath/… 

    …try-relative-units
    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    28c9b99 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'aristath/quote-block-relative-units' into aristath/try-… 

    …relative-units
    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    2041b02 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'button-block-relative-units' into aristath/try-relative… 

    …-units
    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    1ad1c28 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'calendar-block-relatve-units' into aristath/try-relativ… 

    …e-units
    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    dfa8e80 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'p-block-relative-units' into aristath/try-relative-units

    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    7922206 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'aristath/latest-comments-relative-units' into aristath/… 

    …try-relative-units
    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    7ef1e21 View commit details
    Browse the repository at this point in the history

  11. Convert all remaining pixel values to rem

    @aristath
    aristath committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    5479bc0 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Use em instead of rem

    @aristath
    aristath committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    3a2b095 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into aristath/try-relative-units

    @aristath
    aristath committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    4d72408 View commit details
    Browse the repository at this point in the history

  3. Use the vars

    @aristath
    aristath committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    ae64ed0 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. restore original code block padding

    @aristath
    aristath committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    31c5f91 View commit details
    Browse the repository at this point in the history

  2. Update packages/block-library/src/button/style.scss 

    Co-authored-by: Zebulan Stanphill <[email protected]>
    @aristath @ZebulanStanphill
    aristath and ZebulanStanphill authored Aug 14, 2020
    Configuration menu
    Copy the full SHA
    4afbe33 View commit details
    Browse the repository at this point in the history

  3. Update packages/block-library/src/latest-comments/style.scss 

    Co-authored-by: Zebulan Stanphill <[email protected]>
    @aristath @ZebulanStanphill
    aristath and ZebulanStanphill authored Aug 14, 2020
    Configuration menu
    Copy the full SHA
    0e71afe View commit details
    Browse the repository at this point in the history

  4. Move vars to separate "group" and fix comments capitalization

    @aristath
    aristath committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    2b503a2 View commit details
    Browse the repository at this point in the history

  5. this value is closer to the legacy one

    @aristath
    aristath committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    f7cdac1 View commit details
    Browse the repository at this point in the history

  6. no reason for the padding to change here since it was already using em

    @aristath
    aristath committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    9da60ff View commit details
    Browse the repository at this point in the history

  7. Update packages/base-styles/_variables.scss 

    Co-authored-by: Zebulan Stanphill <[email protected]>
    @aristath @ZebulanStanphill
    aristath and ZebulanStanphill authored Aug 14, 2020
    Configuration menu
    Copy the full SHA
    b61eec5 View commit details
    Browse the repository at this point in the history

  8. Value needs to change since it's now relative to the font-size

    @aristath
    aristath committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    3828247 View commit details
    Browse the repository at this point in the history

  9. Fix calculations for relative units in the gallery block

    @aristath
    aristath committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    def9b97 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2020

  1. Fix social links editor styles

    @aristath
    aristath committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    9f7228b View commit details
    Browse the repository at this point in the history

  2. Revert social-icons style mods

    @aristath
    aristath committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    fe5c2f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Merge branch 'master' into aristath/try-relative-units

    @aristath
    aristath committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    2bbcf37 View commit details
    Browse the repository at this point in the history