Recent Comments block: remove hardcoded color #24410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Feature] Themes
jasmussen
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
Yep. Wonderful PR, even if just one line.
The initial reason for adding this color, way back in the day, was probably to give some more utility to the block out of the gate. However the value is dubious and as you note, it interferes even if slightly, with a theme's ability to style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the hardcoded color from
.wp-block-latest-comments__comment-date.If a theme uses a dark background or anything other than white, a hardcoded text-color will not work and themes will be forced to add custom styles and override the defaults.
By removing the custom color definition, the comment-date will use the current text color, therefore avoiding any implications and overrides associated with hardcoded color values.
That selector is already smaller in size, making it lighter in color will only make it harder to read.
If we absolutely need it to have a different color, we could instead use something like
opacity:0.9;. This will keep using the currently defined text-color so it will be OK both for light and dark themes.Also related: #24409 which is a companion to this PR and deals with using relative instead of absolute units for the block.