Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Indicate custom-fields support is required for registering meta #24325

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

shramee
Copy link
Contributor

@shramee shramee commented Aug 3, 2020

Description

Added documentation to explicitly indicate that custom-fields support is required to use register_post_meta.

How has this been tested?

Looked at the rendering on markdown.

Screenshots

Types of changes

Added some footnotes in markdown.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

shramee added 2 commits August 3, 2020 18:54
Post type needs to support `custom-fields` for `register_post_meta` to work.
@shramee shramee changed the title Post types need custom-fields support for registering meta Docs: Indicate custom-fields support is required for registering meta Aug 3, 2020
@Soean Soean added the [Type] Developer Documentation Documentation for developers label Aug 3, 2020
Copy link
Member

@torounit torounit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good thanks!

@mkaz mkaz merged commit 30ee51f into WordPress:master Aug 10, 2020
@github-actions
Copy link

Congratulations on your first merged pull request, @shramee! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 10, 2020
@github-actions github-actions bot added this to the Gutenberg 8.8 milestone Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants