Bug/24286 create block error #24287
Merged
Bug/24286 create block error #24287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 19, 2020 14:14
youknowriad
reviewed
Jul 30, 2020
packages/blocks/src/api/factory.js
Outdated
| */ | ||
| export function createBlock( name, attributes = {}, innerBlocks = [] ) { | ||
| // Get the type definition associated with a registered block. | ||
| const blockType = getBlockType( name ); | ||
|
|
||
| if ( undefined === blockType ) { | ||
| warning( `Block type '${ name }' is not registered.` ); | ||
| return false; |
There was a problem hiding this comment.
Making this non-blocking changes the expectation from someone calling this function.
We do things like that in general in Gutenberg configs.map( config => createBlock( config.name, config.attributes, config.innerBlocks )
With the current implementation, this will hide bugs and just move them down the road. IMO, we should throw an exception here instead of calling warning.
There was a problem hiding this comment.
@youknowriad thanks for the review here! I have updated the PR to throw an exception.
youknowriad
reviewed
Jul 30, 2020
| @@ -46,6 +46,10 @@ export function createBlock( name, attributes = {}, innerBlocks = [] ) { | |||
| // Get the type definition associated with a registered block. | |||
| const blockType = getBlockType( name ); | |||
|
|
|||
| if ( undefined === blockType ) { | |||
There was a problem hiding this comment.
Not important but yoda conditions are not a guideline in JavaScript because we enforce strict equality.
youknowriad
approved these changes
Jul 30, 2020
youknowriad
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24286
Description
This PR implements the proposed solution indicated in #24286
How has this been tested?
Running `wp.blocks.createBlock('not/registered') in the console.
Screenshots
Types of changes
This introduces a warning() call and an early return if the blockType is not registered
Checklist: