Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert <BlockInvalidWarning> to function component with hooks #24284

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Convert <BlockInvalidWarning> to function component with hooks #24284

merged 2 commits into from
Jul 30, 2020

Conversation

kevin940726
Copy link
Member

@kevin940726 kevin940726 commented Jul 30, 2020 •
edited
Loading

Description

Related to #22890.

Convert the <BlockInvalidWarning> component to function component with hooks.

How has this been tested?

  1. Choose an existing block and select "Edit as HTML".
  2. Append <p>Invalid to the end of the HTML to make the block invalid.
  3. Click outside the block, the block should now display the <BlockInvalidWarning>
  4. The component works the same.

Screenshots

image

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

talldan
talldan approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@talldan
Copy link
Contributor

talldan commented Jul 30, 2020

There's one test that seems to be failing regularly on PRs at the moment:
#24281

Merging this despite the failing test as its unrelated code.

@talldan talldan merged commit a7bf428 into WordPress:master Jul 30, 2020
@github-actions github-actions bot added this to the Gutenberg 8.7 milestone Jul 30, 2020
@talldan talldan added [Type] Code Quality Issues or PRs that relate to code quality General Interface Parts of the UI which don't fall neatly under other labels. labels Jul 30, 2020
@kevin940726 kevin940726 deleted the update/invalid-block-warning-hooks branch July 30, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 8.7
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin940726 @talldan