Post Title Block: Add style attributes #24246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
added
[Type] Bug
12 tasks
|
Size Change: +14 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Addison-Stavlo
approved these changes
Jul 28, 2020
|
So this feature is planned to be released with a near future Gutenberg release? |
|
@strarsis Hey! So, these blocks are part of the full site editing project. With a Gutenberg plugin, you can currently go into the "experiments" settings (under Gutenberg in the wp-admin sidebar). There, you can enable the full site editing (FSE) experiment. With that enabled, you can use these blocks, and also try out the early stages of the site editor. These blocks exist in the current Gutenberg plugin with the FSE experiment enabled. These will remain experimental blocks for the near future, though, since everything related to full site editing is under active development. (And things can change a lot.) You should not yet rely on them for production use cases |
|
@noahtallen: Ah, please also notice that posts can have their own headings, too. And for posts having formattable headings (like a subheading) would be also great. |
|
This issue is a helpful overview of FSE blocks: #22724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19491
(last PR needed)
Description
HeadingLevelDropdownto move to the top of the page when changing the heading level.More on the
HeadingLevelDropdownissueTo reproduce, try changing the heading level of a Post Title block from its toolbar.
You'll notice that the block toolbar will disappear, while the heading dropdown remains visible but moved to the top of the screen; since the block is still technically selected, to make the toolbar show up again, you'll need to deselect and reselect it.
I'm not 100% sure about it, but I think it's caused by the re-render upon changing the light block wrapper tag.
I've simply tried copying the approach from another block, and it fixed the issue straight away.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist: