Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to show icon labels. #24234

Merged
merged 4 commits into from
Sep 2, 2020
Merged

Add option to show icon labels. #24234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed98b65
Add option to show icon labels.
tellthemachines Jul 28, 2020
c297f23
Address review feedback and consolidate
tellthemachines Jul 29, 2020
10f78c5
Move option to general section
tellthemachines Jul 31, 2020
30239dc
Remove unnecessary dispatch
tellthemachines Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/edit-post/src/components/options-modal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ export function OptionsModal( { isModalActive, isViewable, closeModal } ) {
'Enable the Most Used Blocks category in the block library'
) }
/>
<EnableFeature
featureName="showIconLabels"
label={ __( 'Show button text labels' ) }
/>
</Section>
<Section title={ __( 'Keyboard options' ) }>
<EnableFeature
Expand Down
4 changes: 4 additions & 0 deletions packages/edit-post/src/components/options-modal/test/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ exports[`OptionsModal should match snapshot when the modal is active 1`] = `
featureName="mostUsedBlocks"
label="Enable the Most Used Blocks category in the block library"
/>
<WithSelect(WithDispatch(BaseOption))
featureName="showIconLabels"
label="Show button text labels"
/>
</Section>
<Section
title="Keyboard options"
Expand Down
1 change: 1 addition & 0 deletions packages/edit-post/src/store/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export const PREFERENCES_DEFAULTS = {
fixedToolbar: false,
welcomeGuide: true,
fullscreenMode: true,
showIconLabels: false,
},
hiddenBlockTypes: [],
preferredStyleVariations: {},
Expand Down