-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code owners for rich text native implementations #24216
Conversation
Size Change: -1.03 MB (89%) 🏆 Total Size: 1.16 MB
ℹ️ View Unchanged
|
SGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Eduardo, Cameron and Paul will be the "native RichText representatives" at this stage.
@SergioEstevao , please check-off the items in the checklist before merging, thanks!
Also, see my comment about the order of mentions, thanks!
.github/CODEOWNERS
Outdated
/packages/format-library @ellatrix @daniloercoli @sergioestevao @etoledom | ||
/packages/rich-text @ellatrix @daniloercoli @sergioestevao @etoledom | ||
/packages/block-editor/src/components/rich-text @ellatrix @daniloercoli @sergioestevao @etoledom | ||
/packages/format-library @ellatrix @etoledom @guarani @cameronvoell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergioEstevao , can you actually put Cameron as the third contact in the list, so we can have better platform coverage (Eduardo is primarily iOS and Cameron is primarily Android) when people read through that list?
…, Android, iOS(2nd)
Description
Change the code owners for the rich text components.
Going forward beside @etoledom, @cameronvoell and @guarani will keep an eye on the rich text components from a RN perspective.
How has this been tested?
Screenshots
Types of changes
Checklist: