Fix gradient RGBA/HSLA inputs' width #24214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
youknowriad
reviewed
Jul 27, 2020
| @@ -178,7 +178,7 @@ export class Inputs extends Component { | |||
| return ( | |||
| <fieldset> | |||
| <VisuallyHidden as="legend"> | |||
| { __( 'Color value in RGB' ) } | |||
| { __( 'Color value in RGBA' ) } | |||
There was a problem hiding this comment.
Do you think this should stay "RGB" unless disableAlpha is false?
There was a problem hiding this comment.
You're right. I missed that. Thanks!
youknowriad
reviewed
Jul 27, 2020
| @@ -231,7 +231,7 @@ export class Inputs extends Component { | |||
| return ( | |||
| <fieldset> | |||
| <VisuallyHidden as="legend"> | |||
| { __( 'Color value in HSL' ) } | |||
| { __( 'Color value in HSLA' ) } | |||
|
Size Change: +198 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jul 27, 2020
| @@ -227,6 +227,11 @@ | |||
| padding-top: 16px; | |||
| display: flex; | |||
| align-items: flex-end; | |||
| min-width: 22em; | |||
There was a problem hiding this comment.
Why do we use "em"s here? It seems like we prefer pixels in general in Gutenberg?
There was a problem hiding this comment.
It is still possible to have the issuue on mobile
I wonder if a better fix is to wrap inputs (return to the line) when they reach a certain size instead of increasing the popover size.
There was a problem hiding this comment.
I wonder if a better fix is to wrap inputs (return to the line)
What do you mean by that?
It seems like we prefer pixels in general in Gutenberg
Okay, I'll use pixels.
Issue on mobile
Is this the min width we should make sure it's shown properly? $break-mobile: 480px;
There was a problem hiding this comment.
I've made the changes to be visible in mobile too with the minimum min-width required.
I wonder if a better fix is to wrap inputs (return to the line) when they reach a certain size instead of increasing the popover size.
@youknowriad just let me know what did you mean, so I can maybe explore a different approach.
If you meant though to listen to input changes and change layout or resize, I believe it would cause an unpleasant/confusing user experience.
youknowriad
approved these changes
Jul 27, 2020
youknowriad
pushed a commit
that referenced
this pull request
Jul 27, 2020
* fix gradient rgba/hsla inputs width * fix label by disableAlpha value * change to px values * css changes
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #24201
When adding a gradient with RGBA or HSLA color values to a block, the increment buttons of number inputs cover up the inputs' values.
Steps to reproduce and screenshots in the issue.