Post Excerpt block: Added icon and description to Post Excerpt block #24203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.01 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
I updated the excerpt description to read, "Display a post's excerpt." |
MichaelArestad
requested changes
Jul 27, 2020
| fill-rule="evenodd" | ||
| clip-rule="evenodd" | ||
| d="M12.75 9.333c0 .521-.102.977-.327 1.354-.23.386-.555.628-.893.774-.545.234-1.183.227-1.544.222l-.12-.001v-1.5h.123c.414.001.715.002.948-.099a.395.395 0 00.199-.166c.05-.083.114-.253.114-.584V7.2H8.8V4h3.95v5.333zM7.95 9.333c0 .521-.102.977-.327 1.354-.23.386-.555.628-.893.774-.545.234-1.183.227-1.544.222l-.12-.001v-1.5h.123c.414.001.715.002.948-.099a.394.394 0 00.198-.166c.05-.083.115-.253.115-.584V7.2H4V4h3.95v5.333zM13 20H4v-1.5h9V20zM20 16H4v-1.5h16V16z" | ||
| fill="#1E1E1E" |
There was a problem hiding this comment.
I would remove this fill.
| import { Path, SVG } from '@wordpress/primitives'; | ||
|
|
||
| const postExcerpt = ( | ||
| <SVG fill="none" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"> |
There was a problem hiding this comment.
Remove this fill as well. (The fills are defined in the CSS so no need here)
| <SVG fill="none" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"> | ||
| <Path | ||
| fill-rule="evenodd" | ||
| clip-rule="evenodd" |
There was a problem hiding this comment.
I'm not sure about these clip and fill rules. I don't really know if they are needed.
MichaelArestad
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added icon and description to Post Excerpt block.
How has this been tested?
Tested locally.
Screenshots
Types of changes
Non-breaking changes.
Checklist: