Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Merge similar translation strings - tables #24169

Merged
merged 5 commits into from
Jul 29, 2020
Merged

i18n: Merge similar translation strings - tables #24169

merged 5 commits into from
Jul 29, 2020

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Jul 23, 2020

Description

This PR merges several similar translation strings to match them to existing strings we have in TinyMCE.

See trac ticket https://core.trac.wordpress.org/ticket/47259

The trac ticket fixes strings in WordPress core, this PR fixes Gutenberg strings.

Screenshots

47259a
47259b
47259c

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ramiy ramiy requested review from nerrad and ntwb as code owners July 23, 2020 20:06
@Soean Soean added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Jul 24, 2020
@Soean Soean added the [Type] Copy Issues or PRs that need copy editing assistance label Jul 28, 2020
@ramiy ramiy requested a review from Soean July 29, 2020 14:03
Soean
Soean approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good improvement.

@Soean Soean merged commit 06db150 into WordPress:master Jul 29, 2020
@github-actions github-actions bot added this to the Gutenberg 8.7 milestone Jul 29, 2020
@ramiy ramiy deleted the patch-3 branch August 4, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soean Soean Soean approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@talldan talldan Awaiting requested review from talldan

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Milestone
Gutenberg 8.7
Development

Successfully merging this pull request may close these issues.
2 participants
@ramiy @Soean