-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap LinkControlSearchInput in forwardRef #24119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Block] Navigation
Affects the Navigation Block
[Feature] Link Editing
Link components (LinkControl, URLInput) and integrations (RichText link formatting)
[Feature] Navigation Screen
labels
Jul 22, 2020
Size Change: -16 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK @adamziel went 110% sure and it works. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Feature] Link Editing
Link components (LinkControl, URLInput) and integrations (RichText link formatting)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As in the title,
ref
needs to be supported in order to embed LinkControlSearchInput on block toolbar.How has this been tested?
Just eyeballing and passing tests should be enough. To be 110% sure, add a navigation block, edit a link, confirm the control looks the same as without this PR.
Types of changes
Non-breaking changes
Checklist: