Fix retrying of post-processing of edited images #24081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HTTP header as back-compat to retry failed post-processing of edited images.
azaozz
added
[Block] Image
|
Size Change: +3 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
Opened https://core.trac.wordpress.org/ticket/50711 for trunk. Going to commit it now, it will start working when this is merged and backported to 5.5 (only the js typo fix matters). |
ellatrix
approved these changes
Aug 10, 2020
ellatrix
added
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Aug 10, 2020
…HTTP header as back-compat to retry failed post-processing of edited images. (#24081)
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The path in apiFetch() in image-editor.js is
wp/v2/media/${ id }/editbut seems it needs to be/wp/v2/media/${ id }/editto match the expected path in the middleware https://github.com/WordPress/gutenberg/blob/master/packages/api-fetch/src/middlewares/media-upload.js#L24.This will fix retrying of image post-processing when saving edited image if the server runs out of resources.
Checklist: