Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navigation Block submenu being overlapped by Cover block overlay #24062

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix Navigation Block submenu being overlapped by Cover block overlay #24062

merged 1 commit into from
Jul 22, 2020

Conversation

alshakero
Copy link
Contributor

Description

This PR increases the z-index, for the submenu flyout. Because currently the flyout is hidden behind the wp-block-cover as shown in this issue.

How has this been tested?

I tested in FF and Chrome.

Screenshots

Available in the issue.

Types of changes

Minor CSS change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Fixes: Automattic/wp-calypso#41737

@talldan talldan added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended labels Jul 22, 2020
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alshakero Thanks for working on this issue. It does seem like there's now a risk the flyout menu will overlap other things it shouldn't, but I don't see many other choices here, so lets merge this and see what happens.

@talldan talldan merged commit bf74f23 into WordPress:master Jul 22, 2020
@github-actions github-actions bot added this to the Gutenberg 8.7 milestone Jul 22, 2020
@talldan talldan changed the title Increase z-index for submenu flyout Fix Navigation Block submenu being overlapped by Cover block overlay Jul 22, 2020
@alshakero alshakero deleted the patch-1 branch July 22, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation block] Sub-menu items added via Navigation block are not clickable
2 participants