Fix blocks dropping to incorrect position in inner block lists #23950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Regression
|
Size Change: -1 B Total Size: 1.14 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Jul 16, 2020
| const sourceBlockIndex = getBlockIndex( sourceClientIds[ 0 ] ); | ||
| const sourceBlockIndex = getBlockIndex( | ||
| sourceClientIds[ 0 ], | ||
| sourceRootClientId |
There was a problem hiding this comment.
Why does getBlockIndex( clientId ) require a second parameter if client IDs are supposed to be unique?
ellatrix
approved these changes
Jul 16, 2020
6 tasks
ellatrix
pushed a commit
that referenced
this pull request
Jul 20, 2020
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a small error in #23825, that resulted in blocks dropping to the incorrect position when moving a block upwards in an inner blocks list.
getBlockIndexrequires the second argument rootClientId, otherwise it assumes the block is in the root block list:https://github.com/WordPress/gutenberg/pull/23825/files#diff-9be26376df0fb6bdabd07fa42395e4ffR263
This PR adds that second argument.
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: