-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Create cover block with custom colour (without an image) #23870
Merged
antonis
merged 52 commits into
WordPress:master
from
antonis:rnmobile/Cover_with_custom_color
Jul 24, 2020
Merged
Changes from 51 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
c608052
Create cover block with only colour (from a default palette)
508f015
Added custom colour swatch
96b1582
Custom Color picker action
8c13787
Hide the block settings button
6e83663
Use noop instead of empty arrow function
3919a7d
Use default settings colors
a2eee4b
WIP: Changes Based on design feedback
83668c7
Merge branch 'master' into rnmobile/23831_Cover_Only_color
c71346a
Merge branch 'master' into rnmobile/23831_Cover_Only_color
a41dc37
Merge branch 'rnmobile/23831_Cover_Only_color' into rnmobile/Cover_wi…
0cbe0c1
Show palette with both hardcoded and theme colors
a0cd93b
Customise media placeholder styles only for the cover component
30d5ccb
Merge branch 'rnmobile/23831_Cover_Only_color' into rnmobile/Cover_wi…
7aec919
Pass only modified media-placeholder styles
a152a4a
Pass only modified color-palette styles
53d5435
Merge branch 'rnmobile/23831_Cover_Only_color' into rnmobile/Cover_wi…
787b462
Fixes lint issue
9929516
Updated color palette height
485cef9
Updated color palette height
91ff055
Use only theme colors
3babed3
Merge branch 'rnmobile/23831_Cover_Only_color' into rnmobile/Cover_wi…
a6a1f3f
Merge branch 'master' into rnmobile/23831_Cover_Only_color
97cc951
Fixes Dark mode styling bug
ecf4147
Merge branch 'rnmobile/23831_Cover_Only_color' into rnmobile/Cover_wi…
60f248d
Use noop instead of empty arrow functions
9036c9e
Simplified media-placeholder props
7d6219f
Removed unnecessary style
201c7d6
Revert "Removed unnecessary style"
77b06a8
Merge branch 'rnmobile/23831_tmp' into rnmobile/Cover_with_custom_color
65fc25e
Merge branch 'rnmobile/23831_tmp' into rnmobile/Cover_with_custom_color
be77f4f
Fixes style issue
2bfd357
Added missing callbacks
e5d0a77
Added bottom label
56449db
Removes unnecessary function
8d2237d
Merge branch 'master' into rnmobile/Cover_with_custom_color
7179432
Apply custom color picker color
d8fbac9
Removes unused import
dc664fb
Lint issues and cleanup
0a37400
Merge branch 'master' into rnmobile/Cover_with_custom_color
0a72e9f
Design fixes
7a4f90d
Renamed prop to declare usage more clearly
8e2c894
Lint Issue
537211c
PR review fixes
df25f6b
Extra fixes to avoid inconsistent states
054a6b5
Lint fix and comment
852f9a4
Revert "Lint fix and comment"
f529dae
Revert "Extra fixes to avoid inconsistent states"
a623b1b
Review changes
b4ab716
Android hardware button handling
979e8d4
Merge branch 'master' into rnmobile/Cover_with_custom_color
a416741
Lint fix
2ae97d2
Removed unused prop/style
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not being used, should we remove it or is there something that we need to add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right @geriux ! This was used at some point during the development but not any more.
I updated the PR