-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'Large header and a paragraph' pattern #23858
Merged
enriquesanchez
merged 2 commits into
master
from
update-large-header-and-paragraph-pattern
Jul 13, 2020
Merged
Update 'Large header and a paragraph' pattern #23858
enriquesanchez
merged 2 commits into
master
from
update-large-header-and-paragraph-pattern
Jul 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquesanchez
added
the
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
label
Jul 10, 2020
enriquesanchez
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
July 10, 2020 02:25
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
This looks pretty good! A couple small thoughts:
|
Thanks @kjellr Added an ellipsis to the heading and a slight line-height increase to the paragraph below it: |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jul 13, 2020
kjellr
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, thanks!
6 tasks
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the layout, text, and color.
Before:
After: