Env: Improve install performance #23806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Build Tooling
noahtallen
changed the title
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
|
There is a permissions issue with |
|
Currently failing in CI with: which is interesting because it worked before 🤔 possible changes affecting it:
|
noahtallen
force-pushed
the
try/wp-env-start-performance-improvement
branch
from
823dc33
to
8440abc
Compare
|
Everything should be fixed now. We'll just leave the command for phpunit config the same since it might be removed with #23171 |
epiqueras
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #23175. Improves startup performance by not re-launching the docker service over and over again. Rather, we run all the commands in bash with a single service execution.
Additionally, I removed the behavior which activates the first theme in the list. I personally think this is ok to do since it's really annoying to have your chosen theme be overwritten every time you start wp-env.
How has this been tested?
Locally in wp-env; CI should pass
Performance improvement
Each value below is the fastest run time out of 5 runs.
In general, we see that wp-env runs around 14 seconds faster, which about twice as fast in normal use cases. We can further improve this by avoiding WordPress configuration when nothing has changed in the config files.
Types of changes
Checklist: