Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Correct post title focus #23683

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Conversation

lukewalczak
Copy link
Member

Description

Correct post title focus behaviour which should be blurred when another block is selected

How has this been tested?

  1. Open mobile app
  2. Create a new post
  3. Select post title and type something
  4. Press inserter and add block such as Media & Text or Latest Posts
  5. Expect the post title is not focused either selected.

Screenshots

before after
title_wrong title_correct

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@lukewalczak lukewalczak added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jul 3, 2020
@lukewalczak lukewalczak mentioned this pull request Jul 3, 2020
6 tasks
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

Size Change: +1.88 kB (0%)

Total Size: 1.13 MB

Filename Size Change
build/annotations/index.js 3.68 kB +53 B (1%)
build/autop/index.js 2.82 kB +1 B
build/block-directory/index.js 7.67 kB +512 B (6%) 🔍
build/block-editor/index.js 110 kB +1.03 kB (0%)
build/block-editor/style-rtl.css 10.7 kB +7 B (0%)
build/block-editor/style.css 10.7 kB +7 B (0%)
build/block-library/editor-rtl.css 7.57 kB -48 B (0%)
build/block-library/editor.css 7.57 kB -48 B (0%)
build/block-library/index.js 130 kB +246 B (0%)
build/block-serialization-default-parser/index.js 1.88 kB -1 B
build/block-serialization-spec-parser/index.js 3.1 kB -5 B (0%)
build/blocks/index.js 48.2 kB +71 B (0%)
build/components/index.js 199 kB +74 B (0%)
build/components/style-rtl.css 15.8 kB +4 B (0%)
build/components/style.css 15.8 kB +4 B (0%)
build/compose/index.js 9.56 kB -89 B (0%)
build/data-controls/index.js 1.29 kB +2 B (0%)
build/data/index.js 8.44 kB +1 B
build/date/index.js 5.38 kB -89 B (1%)
build/dom/index.js 3.23 kB +38 B (1%)
build/edit-navigation/index.js 9.93 kB -47 B (0%)
build/edit-post/index.js 304 kB +136 B (0%)
build/edit-site/index.js 16.6 kB -88 B (0%)
build/edit-widgets/index.js 9.35 kB +25 B (0%)
build/editor/index.js 45 kB +193 B (0%)
build/editor/style-rtl.css 3.78 kB +4 B (0%)
build/editor/style.css 3.78 kB +5 B (0%)
build/element/index.js 4.65 kB +1 B
build/format-library/index.js 7.73 kB -1 B
build/hooks/index.js 2.13 kB +2 B (0%)
build/keyboard-shortcuts/index.js 2.52 kB +5 B (0%)
build/keycodes/index.js 1.94 kB +2 B (0%)
build/media-utils/index.js 5.32 kB +22 B (0%)
build/notices/index.js 1.79 kB +4 B (0%)
build/nux/index.js 3.41 kB +2 B (0%)
build/primitives/index.js 1.41 kB -92 B (6%)
build/rich-text/index.js 13.9 kB -95 B (0%)
build/server-side-render/index.js 2.71 kB +37 B (1%)
build/viewport/index.js 1.85 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 944 B 0 B
build/block-directory/style.css 945 B 0 B
build/block-library/style-rtl.css 7.78 kB 0 B
build/block-library/style.css 7.79 kB 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/core-data/index.js 11.4 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/edit-navigation/style-rtl.css 1.02 kB 0 B
build/edit-navigation/style.css 1.02 kB 0 B
build/edit-post/style-rtl.css 5.57 kB 0 B
build/edit-post/style.css 5.57 kB 0 B
build/edit-site/style-rtl.css 3.03 kB 0 B
build/edit-site/style.css 3.03 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/priority-queue/index.js 788 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@lukewalczak lukewalczak merged commit 572c1bc into master Jul 9, 2020
@lukewalczak lukewalczak deleted the rnmobile/fix-post-title-focus branch July 9, 2020 14:35
@github-actions github-actions bot added this to the Gutenberg 8.6 milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants