Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload icon. #23553

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Fix upload icon. #23553

merged 1 commit into from
Jun 30, 2020

Conversation

jasmussen
Copy link
Contributor

@jasmussen jasmussen commented Jun 29, 2020

This fixes a vector error in the upload icon, and sizes it correctly. Before:

Screenshot 2020-06-29 at 10 59 13

After:

Screenshot 2020-06-29 at 11 02 33

Note how the top of the arrow was abruptly cropped off. That's been fixed. The size prop has also been removed, as the bigger icon did not add value, just complexity, and with #23454 the blue color will make it more visible anyway.

@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Jun 29, 2020
@jasmussen jasmussen self-assigned this Jun 29, 2020
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jasmussen !

@jasmussen jasmussen merged commit 5e6684a into master Jun 30, 2020
@jasmussen jasmussen deleted the fix/upload-icon branch June 30, 2020 07:09
@github-actions github-actions bot added this to the Gutenberg 8.5 milestone Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants