Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #19940. Added common steps of plugin translation #23535

Merged
merged 4 commits into from
Jul 27, 2021
Merged

fix #19940. Added common steps of plugin translation #23535

merged 4 commits into from
Jul 27, 2021

Conversation

atachibana
Copy link
Contributor

Description

This PR will fix issue #19940 of @mkaz.
For new translators, added general description about WordPress Translation and link to Polyglots handbook.

How has this been tested?

Spell and grammar were checked on https://www.online-spellcheck.com/result/ba540f6ce8ca06822999f9a1de3c99a599bbe87b
Two links are reachable.

Screenshots

n/a

Types of changes

Added the 1st paragraph.

Checklist:

  • [n/a] My code is tested.
  • [n/a] My code follows the WordPress code style.
  • [n/a] My code follows the accessibility standards.
  • [n/a] My code has proper inline documentation.
  • [n/a] I've included developer documentation if appropriate.
  • [n/a] I've updated all React Native files affected by any refactorings/renamings in this PR.

mkaz
mkaz approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating and the link to more information.

@mkaz mkaz mentioned this pull request Jul 9, 2020
Merged
Base automatically changed from master to trunk March 1, 2021 15:43
@mkaz mkaz requested a review from aristath May 6, 2021 22:10
@aristath
Copy link
Member

The failing test is not related to this PR, I'll go ahead and merge it.

@aristath aristath merged commit 41ef4a7 into WordPress:trunk Jul 27, 2021
@github-actions github-actions bot added this to the Gutenberg 11.2 milestone Jul 27, 2021
@talldan
Copy link
Contributor

talldan commented Jul 28, 2021

@mkaz @aristath Please could you make sure PRs have appropriate titles and labels when reviewing or merging. Thanks.

@talldan talldan added the [Type] Developer Documentation Documentation for developers label Jul 28, 2021
@atachibana atachibana deleted the fix-doc-i18n branch August 22, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

@aristath aristath aristath approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees
No one assigned
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 11.2
Development

Successfully merging this pull request may close these issues.
4 participants
@atachibana @aristath @talldan @mkaz