-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: Add shortcode block #2352
Conversation
blocks/library/shortcode/index.js
Outdated
registerBlockType( 'core/shortcode', { | ||
title: __( 'Shortcode' ), | ||
|
||
icon: 'editor-code', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasmussen could we get a special icon here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtias @jasmussen Regarding a special icon. See WordPress/dashicons#261.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll put this on my list, thanks for the reminder!
Codecov Report
@@ Coverage Diff @@
## master #2352 +/- ##
==========================================
+ Coverage 24.69% 24.83% +0.13%
==========================================
Files 152 153 +1
Lines 4738 4752 +14
Branches 799 801 +2
==========================================
+ Hits 1170 1180 +10
- Misses 3014 3018 +4
Partials 554 554
Continue to review full report at Codecov.
|
It seems we have an issue with attaching images to posts because |
Whoa nice, igniting all test procedures. |
Hmm, this is meant to be working, was part of #1967. |
…_captions Issue/426 fix enter on captions
Closes #1709
This pull request seeks to implement a new Shortcode block:
Testing instructions:
Verify that you can add a shortcode block, and that it is saved into post content with no additional surrounding elements.