Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu items REST API] Perform validation and sanitization separately from saving #23474

Closed
wants to merge 26 commits into from
Closed

[Menu items REST API] Perform validation and sanitization separately from saving #23474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
bdf5335
Restore schema-based title validation (and disable broken tests for now)
adamziel Jun 24, 2020
fe37af3
Schema-based title property
adamziel Jun 25, 2020
6de74d1
Schema-based object property
adamziel Jun 26, 2020
a8a49ed
More schema-based validation
adamziel Jun 26, 2020
23899e3
Restore object id sanitization logic to prepare_item_for_db
adamziel Jun 26, 2020
e6f4bc9
Add comments
adamziel Jun 26, 2020
e69ef47
Schema-based menu id validation
adamziel Jun 26, 2020
894cc5f
Schema-based menu id validation
adamziel Jun 26, 2020
e284c0e
Schema-based menu id validation
adamziel Jun 26, 2020
c0b04ad
Rename prepare_item_for_database -> prepare_item_for_sanitization
adamziel Jun 26, 2020
65f121d
Post type validation moved to sanitize_callback
adamziel Jun 26, 2020
fcc147b
Clean up dev artifacts
adamziel Jun 26, 2020
8e95458
Get rid of prepare_item_for_sanitization
adamziel Jun 26, 2020
ffaf72f
Remove dev artifact
adamziel Jun 26, 2020
b8f7ac6
Lint and remove unused parameters
adamziel Jun 26, 2020
ac11aaa
Rollback phpunit.xml.dist changes
adamziel Jun 26, 2020
e8cd0f2
Simplify validate_callback of title parameter
adamziel Jun 26, 2020
0077dd5
First step towards rebasing on top of batch validation branch
adamziel Jun 26, 2020
a55840e
Move the "global" sanitization logic into the sanitize function
adamziel Jun 29, 2020
2a86560
Lint
adamziel Jun 29, 2020
fb835b6
Remove dev artifact
adamziel Jun 29, 2020
1c5ce92
Sanitize the request itself, not the params
adamziel Jun 29, 2020
70a07cd
Formatting
adamziel Jun 29, 2020
0a18888
Formatting
adamziel Jun 29, 2020
b1a07dc
Formatting
adamziel Jun 29, 2020
b1ffaf3
Tighten the title validation and sanitization
adamziel Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading