Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added readme to matrix alignment toolbar #23341

Merged
merged 5 commits into from
Jul 9, 2020
Merged

added readme to matrix alignment toolbar #23341

merged 5 commits into from
Jul 9, 2020

Conversation

alita-moore
Copy link
Contributor

Description

Added documentation to the matrix alignment toolbar in concordance with #22891

How has this been tested?

N/A, documentation only

Screenshots

Types of changes

Documentation

Checklist:

  • [n/a] My code is tested.
  • [n/a] My code follows the WordPress code style.
  • [n/a] My code follows the accessibility standards.
  • [n/a] My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@youknowriad youknowriad requested a review from ItsJonQ June 21, 2020 09:34
@ZebulanStanphill ZebulanStanphill added the [Type] Developer Documentation Documentation for developers label Jun 21, 2020
@alita-moore alita-moore requested a review from youknowriad June 24, 2020 22:06
@youknowriad youknowriad added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Jun 25, 2020
@michelleweber
Copy link

Hi! I'm not totally clear on what copy you actually need reviewed, could you advise?

@alita-moore
Copy link
Contributor Author

Hi! I'm not totally clear on what copy you actually need reviewed, could you advise?

both are the same, I re-commited because I thought that the pull request number was mandatory :)

@alita-moore alita-moore reopened this Jun 30, 2020
youknowriad
youknowriad reviewed Jun 30, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. This is looking good to me. Left small notes.

@alita-moore alita-moore requested a review from youknowriad July 9, 2020 02:39
@youknowriad youknowriad merged commit d3503d4 into WordPress:master Jul 9, 2020
@youknowriad
Copy link
Contributor

Thanks for your help here 👍

@github-actions
Copy link

github-actions bot commented Jul 9, 2020

Congratulations on your first merged pull request, @alita-moore! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 9, 2020
@github-actions github-actions bot added this to the Gutenberg 8.6 milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@ItsJonQ ItsJonQ Awaiting requested review from ItsJonQ

@mkaz mkaz Awaiting requested review from mkaz

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 8.6
Development

Successfully merging this pull request may close these issues.
5 participants
@alita-moore @michelleweber @youknowriad @ItsJonQ @ZebulanStanphill